ProfileManager doesn't depend on "--login-profile" switch.

chrome/browser/profiles/profile_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/path_service.h"
@@ skipping 27 matching lines @@
 #include "components/signin/core/common/profile_management_switches.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "grit/generated_resources.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/login/users/mock_user_manager.h"
-#include "chrome/browser/chromeos/login/users/user_manager.h"
+#include "chrome/browser/chromeos/login/users/fake_user_manager.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/login/user_names.h"
 #endif
 
 using base::ASCIIToUTF16;
 using content::BrowserThread;
 
 namespace {
@@ skipping 42 matching lines @@
       : local_state_(TestingBrowserProcess::GetGlobal()) {
   }
 
   virtual void SetUp() {
     // Create a new temporary directory, and store the path
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
     TestingBrowserProcess::GetGlobal()->SetProfileManager(
         new UnittestProfileManager(temp_dir_.path()));
 
 #if defined(OS_CHROMEOS)
-  CommandLine* cl = CommandLine::ForCurrentProcess();
-  cl->AppendSwitch(switches::kTestType);
+    CommandLine* cl = CommandLine::ForCurrentProcess();
+    cl->AppendSwitch(switches::kTestType);
 #endif
   }
 
   virtual void TearDown() {
     TestingBrowserProcess::GetGlobal()->SetProfileManager(NULL);
     base::RunLoop().RunUntilIdle();
   }
 
   // Helper function to create a profile with |name| for a profile |manager|.
   void CreateProfileAsync(ProfileManager* manager,
@@ skipping 17 matching lines @@
     ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
     size_t num_profiles = cache.GetNumberOfProfiles();
     base::FilePath path = temp_dir_.path().AppendASCII(path_suffix);
     cache.AddProfileToCache(path, profile_name,
                             base::string16(), 0, std::string());
     EXPECT_EQ(num_profiles + 1, cache.GetNumberOfProfiles());
     return profile_manager->GetProfile(path);
   }
 
 #if defined(OS_CHROMEOS)
+  // Helper function to register an user with id |user_id| and create profile
+  // for him with a correct path.

[Mr4D (OOO till 08-26), 2014/08/15 14:27:56]

remove "for him".

[dzhioev (left Google), 2014/08/15 16:11:25]

Done.

+  void RegisterUser(const std::string& user_id) {
+    chromeos::ProfileHelper* profile_helper = chromeos::ProfileHelper::Get();
+    const std::string user_id_hash =
+        profile_helper->GetUserIdHashByUserIdForTests(user_id);
+    chromeos::UserManager::Get()->UserLoggedIn(
+        user_id,
+        user_id_hash,
+        false);
+    g_browser_process->profile_manager()->GetProfile(
+        profile_helper->GetProfilePathByUserIdHash(user_id_hash));
+  }
+
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
 #endif
 
   // The path to temporary directory used to contain the test operations.
   base::ScopedTempDir temp_dir_;
   ScopedTestingLocalState local_state_;
 
   content::TestBrowserThreadBundle thread_bundle_;
 
 #if defined(OS_CHROMEOS)
   chromeos::ScopedTestUserManager test_user_manager_;
 #endif

[Mr4D (OOO till 08-26), 2014/08/15 14:27:56]

Could you add DISALLOW_COPY_AND_ASSIGN here?

[dzhioev (left Google), 2014/08/15 16:11:25]

Done.

 };
 
 TEST_F(ProfileManagerTest, GetProfile) {
   base::FilePath dest_path = temp_dir_.path();
   dest_path = dest_path.Append(FILE_PATH_LITERAL("New Profile"));
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
 
   // Successfully create a profile.
   Profile* profile = profile_manager->GetProfile(dest_path);
   EXPECT_TRUE(profile);
 
   // The profile already exists when we call GetProfile. Just load it.
   EXPECT_EQ(profile, profile_manager->GetProfile(dest_path));
 }
 
 TEST_F(ProfileManagerTest, DefaultProfileDir) {
   base::FilePath expected_default =
       base::FilePath().AppendASCII(chrome::kInitialProfile);
   EXPECT_EQ(
       expected_default.value(),
       g_browser_process->profile_manager()->GetInitialProfileDir().value());
 }
 
 #if defined(OS_CHROMEOS)
+
 // This functionality only exists on Chrome OS.
 TEST_F(ProfileManagerTest, LoggedInProfileDir) {
-  CommandLine *cl = CommandLine::ForCurrentProcess();
-  std::string profile_dir(chrome::kTestUserProfileDir);
-
-  cl->AppendSwitchASCII(chromeos::switches::kLoginProfile, profile_dir);
-
   base::FilePath expected_default =
       base::FilePath().AppendASCII(chrome::kInitialProfile);
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   EXPECT_EQ(expected_default.value(),
             profile_manager->GetInitialProfileDir().value());
 
-  scoped_ptr<chromeos::MockUserManager> mock_user_manager;
-  mock_user_manager.reset(new chromeos::MockUserManager());
-  mock_user_manager->SetActiveUser("user@gmail.com");
-  user_manager::User* active_user = mock_user_manager->GetActiveUser();
+  const char kTestUserName[] = "test-user@example.com";
+  chromeos::FakeUserManager* user_manager = new chromeos::FakeUserManager();
+  chromeos::ScopedUserManagerEnabler enabler(user_manager);
+
+  const user_manager::User* active_user = user_manager->AddUser(kTestUserName);
+  user_manager->LoginUser(kTestUserName);
+  user_manager->SwitchActiveUser(kTestUserName);
+
   profile_manager->Observe(
       chrome::NOTIFICATION_LOGIN_USER_CHANGED,
       content::NotificationService::AllSources(),
       content::Details<const user_manager::User>(active_user));
-  base::FilePath expected_logged_in(profile_dir);
+  base::FilePath expected_logged_in(
+      chromeos::ProfileHelper::GetUserProfileDir(active_user->username_hash()));
   EXPECT_EQ(expected_logged_in.value(),
             profile_manager->GetInitialProfileDir().value());
   VLOG(1) << temp_dir_.path().Append(
       profile_manager->GetInitialProfileDir()).value();
 }
 
 #endif
 
 TEST_F(ProfileManagerTest, CreateAndUseTwoProfiles) {
   base::FilePath dest_path1 = temp_dir_.path();
@@ skipping 170 matching lines @@
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
     TestingBrowserProcess::GetGlobal()->SetProfileManager(
         new UnittestGuestProfileManager(temp_dir_.path()));
 
 #if defined(OS_CHROMEOS)
     CommandLine* cl = CommandLine::ForCurrentProcess();
     // This switch is needed to skip non-test specific behavior in
     // ProfileManager (accessing DBusThreadManager).
     cl->AppendSwitch(switches::kTestType);
 
-    cl->AppendSwitchASCII(chromeos::switches::kLoginProfile,
-                          std::string(chrome::kProfileDirPrefix) +
-                              chromeos::login::kGuestUserName);
     cl->AppendSwitch(chromeos::switches::kGuestSession);
     cl->AppendSwitch(::switches::kIncognito);
 
-    chromeos::UserManager::Get()->UserLoggedIn(chromeos::login::kGuestUserName,
-                                               chromeos::login::kGuestUserName,
-                                               false);
+    RegisterUser(chromeos::login::kGuestUserName);
 #endif
   }
 };
 
 TEST_F(ProfileManagerGuestTest, GetLastUsedProfileAllowedByPolicy) {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   ASSERT_TRUE(profile_manager);
 
   Profile* profile = profile_manager->GetLastUsedProfileAllowedByPolicy();
   ASSERT_TRUE(profile);
@@ skipping 119 matching lines @@
   EXPECT_EQ(profile_name,
             base::UTF16ToUTF8(cache.GetNameOfProfileAtIndex(profile_index)));
   EXPECT_EQ(avatar_index,
             cache.GetAvatarIconIndexOfProfileAtIndex(profile_index));
 }
 
 TEST_F(ProfileManagerTest, GetLastUsedProfileAllowedByPolicy) {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   ASSERT_TRUE(profile_manager);
 
+#if defined(OS_CHROMEOS)
+  // On CrOS, profile returned by GetLastUsedProfile is an singin profile that
+  // is forced to be incognito. That's why we need to create at least one user
+  // to get a regular profile.
+  RegisterUser("test-user@example.com");
+#endif
+
   Profile* profile = profile_manager->GetLastUsedProfileAllowedByPolicy();
   ASSERT_TRUE(profile);
   EXPECT_FALSE(profile->IsOffTheRecord());
   PrefService* prefs = profile->GetPrefs();
   EXPECT_EQ(IncognitoModePrefs::ENABLED,
             IncognitoModePrefs::GetAvailability(prefs));
 
   ASSERT_TRUE(profile->GetOffTheRecordProfile());
 
   IncognitoModePrefs::SetAvailability(prefs, IncognitoModePrefs::DISABLED);
@@ skipping 647 matching lines @@
                          dest_path2.BaseName().MaybeAsASCII());
   profile_manager->ScheduleProfileForDeletion(dest_path2,
                                               ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(dest_path3, profile_manager->GetLastUsedProfile()->GetPath());
   EXPECT_EQ(profile_name3, local_state->GetString(prefs::kProfileLastUsed));
 }
 #endif  // !defined(OS_MACOSX)