Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 442033002: [Ozone] Do not warp cursor for synthesized events (Closed)

Created:
6 years, 4 months ago by dnicoara
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Ozone] Do not warp cursor for synthesized events This behavior is similar to not having a native event on the non-Ozone path. Synthesized events were processed after the ScreenPositionClient was removed from the window. Trying to convert the cursor point to screen coordinates would trigger a CHECK in ash::wm::ConvertPointToScreen since these synthesized events would be processed as the WindowTreeHost was shutdown. BUG=398888 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ash/display/mouse_cursor_event_filter_ozone.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dnicoara
PTAL
6 years, 4 months ago (2014-08-05 17:00:56 UTC) #1
oshima
lgtm
6 years, 4 months ago (2014-08-06 19:48:06 UTC) #2
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 4 months ago (2014-08-06 19:59:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/442033002/1
6 years, 4 months ago (2014-08-06 20:00:44 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 20:03:44 UTC) #5
Message was sent while issue was closed.
Change committed as 287837

Powered by Google App Engine
This is Rietveld 408576698