Issue 442019: Fix keyboard focus in initial sync dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 442019: Fix keyboard focus in initial sync dialogs. (Closed)

Created:
11 years ago by chron_chromium.org

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix keyboard focus in initial sync dialogs. Remove stray style tag that caused validation problems. TEST=manually tested BUG=28803, 28801 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33165

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	chrome/browser/sync/resources/merge_and_sync.html	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/resources/setup_done.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/resources/setup_flow.html	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

tim (not reviewing)

11 years ago (2009-11-26 01:09:45 UTC) #2

On 2009/11/26 00:54:11, chron_chromium.org wrote:
> 

LGTM!!