Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 442003002: Fix disassembly of sar(_, imm8) (Closed)

Created:
6 years, 4 months ago by Jakob Kummerow
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ia32/disasm-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/disasm-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
6 years, 4 months ago (2014-08-05 14:53:25 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-06 04:05:54 UTC) #2
Jakob Kummerow
6 years, 4 months ago (2014-08-06 08:19:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698