Check that external references are registered in the serializer.

src/serialize.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/base/platform/platform.h"
 #include "src/bootstrapper.h"
@@ skipping 380 matching lines @@
       36,
       "LDoubleConstant::min_int");
   Add(ExternalReference::address_of_one_half().address(),
       UNCLASSIFIED,
       37,
       "LDoubleConstant::one_half");
   Add(ExternalReference::isolate_address(isolate).address(),
       UNCLASSIFIED,
       38,
       "isolate");
-  Add(ExternalReference::address_of_minus_zero().address(),
-      UNCLASSIFIED,
-      39,
-      "LDoubleConstant::minus_zero");
   Add(ExternalReference::address_of_negative_infinity().address(),
       UNCLASSIFIED,
       40,
       "LDoubleConstant::negative_infinity");
   Add(ExternalReference::power_double_double_function(isolate).address(),
       UNCLASSIFIED,
       41,
       "power_double_double_function");
   Add(ExternalReference::power_double_int_function(isolate).address(),
       UNCLASSIFIED,
@@ skipping 105 matching lines @@
       UNCLASSIFIED,
       66,
       "Debug::after_break_target_address()");
 
   Add(ExternalReference::debug_restarter_frame_function_pointer_address(
           isolate).address(),
       UNCLASSIFIED,
       67,
       "Debug::restarter_frame_function_pointer_address()");
 
+  Add(ExternalReference::flush_icache_function(isolate).address(), UNCLASSIFIED,
+      68, "CpuFeatures::FlushICache");
+
+  Add(ExternalReference::log_enter_external_function(isolate).address(),
+      UNCLASSIFIED, 69, "Logger::EnterExternal");
+
+  Add(ExternalReference::log_leave_external_function(isolate).address(),
+      UNCLASSIFIED, 70, "Logger::LeaveExternal");
+
+  Add(ExternalReference::address_of_minus_one_half().address(), UNCLASSIFIED,
+      71, "double_constants.minus_one_half");
+
+  Add(ExternalReference::stress_deopt_count(isolate).address(), UNCLASSIFIED,
+      72, "Isolate::stress_deopt_count_address()");
+
+  Add(ExternalReference::debug_is_active_address(isolate).address(),
+      UNCLASSIFIED, 73, "Debug::is_active_address()");
+
+  Add(ExternalReference::incremental_marking_record_write_function(isolate)
+          .address(),
+      UNCLASSIFIED, 74, "IncrementalMarking::RecordWriteFromCode");
+
+  Add(ExternalReference::math_log_double_function(isolate).address(),
+      UNCLASSIFIED, 75, "std::log");
+
   // Add a small set of deopt entry addresses to encoder without generating the
   // deopt table code, which isn't possible at deserialization time.
   HandleScope scope(isolate);
   for (int entry = 0; entry < kDeoptTableSerializeEntryCount; ++entry) {
     Address address = Deoptimizer::GetDeoptimizationEntry(
         isolate,
         entry,
         Deoptimizer::LAZY,
         Deoptimizer::CALCULATE_ENTRY_ADDRESS);
     Add(address, LAZY_DEOPTIMIZATION, entry, "lazy_deopt");
   }
+
+#ifdef DEBUG
+  // Make sure that we do not have duplicate codes.
+  refs_.Sort(&Compare);
+  for (int i = 0; i < refs_.length() - 1; i++) CHECK(code(i) != code(i + 1));

[Jakob Kummerow, 2014/08/05 13:12:07]

With a little reordering of the TypeCode enum, you could guarantee ascending
(and, hence, unique) codes in linear time without sorting:

int last_seen = -1;
for(int i = 0; i < refs.length(); i++) {
  CHECK(code(i) > last_seen);
  last_seen = code(i);
}

Just for your consideration, I'm fine with either approach.

+#endif  // DEBUG
 }
 
 
 ExternalReferenceEncoder::ExternalReferenceEncoder(Isolate* isolate)
     : encodings_(HashMap::PointersMatch),
       isolate_(isolate) {
   ExternalReferenceTable* external_references =
       ExternalReferenceTable::instance(isolate_);
   for (int i = 0; i < external_references->size(); ++i) {
     Put(external_references->address(i), i);
@@ skipping 1519 matching lines @@
 
 int SerializedCodeData::CheckSum(String* string) {
   int checksum = Version::Hash();
 #ifdef DEBUG
   uint32_t seed = static_cast<uint32_t>(checksum);
   checksum = static_cast<int>(IteratingStringHasher::Hash(string, seed));
 #endif  // DEBUG
   return checksum;
 }
 } }  // namespace v8::internal