Issue 441973002: PastePopup Menu icon is different for separate scenarios

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 441973002: PastePopup Menu icon is different for separate scenarios (Closed)

Created:
6 years, 4 months ago by kingshuk.j

Modified:
6 years, 4 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam, AKVT, Cyan, raghu, AviD

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

PastePopup Menu icon is different for separate scenarios PastePopup Menu is currently using the android provided layout attributes while displaying the popup beside handler or above it. Need to use same UI for both scenarios when we show the PastePopupMenu. BUG=400705 Signed-off-by: Kingshuk Jana <kingshuk.j@samsung.com>;

Patch Set 1 #

Patch Set 2 : Used only one type of layout attribute for popup #

Patch Set 3 : Removed unused attribute onTop #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -28 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java	View	1 2	4 chunks	+15 lines, -28 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kingshuk.j

6 years, 4 months ago (2014-08-13 04:14:56 UTC) #1

Closing this issue as this change has been merged with and committed at
https://codereview.chromium.org/449033002/