Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 441953002: Inactive password bubble should dissappear after timeout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rearrange Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 55dfde9866b8dc7c182eaf618b12be396523e038..8069b5d6cdb988990146a470d6041e1c3cbdf5dc 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -34,6 +34,9 @@
namespace {
+// The number of seconds the inactive bubble should stay alive.
+const int kBubbleCloseDelay = 15;
+
const int kDesiredBubbleWidth = 370;
enum ColumnSetType {
@@ -551,6 +554,7 @@ void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
manage_passwords_bubble_->GetWidget()->ShowInactive();
else
manage_passwords_bubble_->GetWidget()->Show();
+ manage_passwords_bubble_->StartTimerIfNecessary();
}
// static
@@ -579,6 +583,7 @@ ManagePasswordsBubbleView::ManagePasswordsBubbleView(
initially_focused_view_(NULL) {
// Compensate for built-in vertical padding in the anchor view's image.
set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
+ set_notify_enter_exit_on_child(true);
if (anchor_view)
anchor_view->SetActive(true);
}
@@ -620,10 +625,25 @@ void ManagePasswordsBubbleView::WindowClosing() {
manage_passwords_bubble_ = NULL;
}
+void ManagePasswordsBubbleView::OnWidgetActivationChanged(views::Widget* widget,
+ bool active) {
+ if (active && widget == GetWidget())
+ timer_.Stop();
+ BubbleDelegateView::OnWidgetActivationChanged(widget, active);
+}
+
views::View* ManagePasswordsBubbleView::GetInitiallyFocusedView() {
return initially_focused_view_;
}
+void ManagePasswordsBubbleView::OnMouseEntered(const ui::MouseEvent& event) {
+ timer_.Stop();
+}
+
+void ManagePasswordsBubbleView::OnMouseExited(const ui::MouseEvent& event) {
+ StartTimerIfNecessary();
+}
+
void ManagePasswordsBubbleView::Refresh() {
RemoveAllChildViews(true);
initially_focused_view_ = NULL;
@@ -640,6 +660,9 @@ void ManagePasswordsBubbleView::Refresh() {
AddChildView(new ManageView(this));
}
GetLayoutManager()->Layout(this);
+ // If we refresh the existing bubble we may want to restart the timer.
+ if (GetWidget())
+ StartTimerIfNecessary();
}
void ManagePasswordsBubbleView::NotifyNeverForThisSiteClicked() {
@@ -661,3 +684,13 @@ void ManagePasswordsBubbleView::NotifyUndoNeverForThisSite() {
never_save_passwords_ = false;
Refresh();
}
+
+void ManagePasswordsBubbleView::StartTimerIfNecessary() {
+ // Active bubble will stay visible until it loses focus.
+ if (GetWidget()->IsActive())
+ return;
+ timer_.Start(FROM_HERE,
+ base::TimeDelta::FromSeconds(kBubbleCloseDelay),
+ this,
+ &ManagePasswordsBubbleView::Close);
+}

Powered by Google App Engine
This is Rietveld 408576698