Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 441913002: Check animation notify values first while sending notification to Observers (Closed)

Created:
6 years, 4 months ago by shreyas.g
Modified:
6 years, 4 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, Sikugu_, MuVen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: check animation notify settings first in NotifyObservers (like LayerAnimationController::NotifyObserversOpacityAnimated) While sending the notification to the observers, the notify settings of the animation (active and pending) are checked against the state of the observer (whether active or not). In most cases, the default setting of the animation will set active and pending as true. So in those cases there is no need to check for the active state of observer. This patch first checks if both active and pending state are true for animation. If yes then it proceedes sending the notification to observer and there is no need to check the active state of observer. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287554

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added variables back into PropertyUpdate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M cc/animation/layer_animation_controller.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
shreyas.g
PTAL.
6 years, 4 months ago (2014-08-05 10:24:28 UTC) #1
ajuma
Mostly looks good, except for one thing: https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation_controller.cc File cc/animation/layer_animation_controller.cc (left): https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation_controller.cc#oldcode369 cc/animation/layer_animation_controller.cc:369: bool notify_pending_observers ...
6 years, 4 months ago (2014-08-05 13:05:58 UTC) #2
shreyas.g
https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation_controller.cc File cc/animation/layer_animation_controller.cc (left): https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation_controller.cc#oldcode369 cc/animation/layer_animation_controller.cc:369: bool notify_pending_observers = true; On 2014/08/05 13:05:57, ajuma wrote: ...
6 years, 4 months ago (2014-08-05 13:41:52 UTC) #3
ajuma
lgtm
6 years, 4 months ago (2014-08-05 14:31:55 UTC) #4
shreyas.g
The CQ bit was checked by shreyas.g@samsung.com
6 years, 4 months ago (2014-08-05 14:32:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreyas.g@samsung.com/441913002/20001
6 years, 4 months ago (2014-08-05 14:33:03 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 17:09:25 UTC) #7
Message was sent while issue was closed.
Change committed as 287554

Powered by Google App Engine
This is Rietveld 408576698