Check animation notify values first while sending notification to Observers

cc: check animation notify settings first in NotifyObservers
(like LayerAnimationController::NotifyObserversOpacityAnimated)

While sending the notification to the observers, the notify settings 
of the animation (active and pending) are checked against the state of
the observer (whether active or not). In most cases, the default 
setting of the animation will set active and pending as true. So in 
those cases there is no need to check for the active state of observer.

This patch first checks if both active and pending state are true for 
animation. If yes then it proceedes sending the notification to 
observer and there is no need to check the active state of observer.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287554

[shreyas.g, 2014-08-05 10:24:28]

PTAL.

[ajuma, 2014-08-05 13:05:58]

Mostly looks good, except for one thing:

https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation...
File cc/animation/layer_animation_controller.cc (left):

https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation...
cc/animation/layer_animation_controller.cc:369: bool notify_pending_observers =
true;
These variables act as a form of documentation allowing someone reading this
code to understand what the 'true' arguments being passed below mean. So these
should not be removed.

[shreyas.g, 2014-08-05 13:41:52]

https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation...
File cc/animation/layer_animation_controller.cc (left):

https://codereview.chromium.org/441913002/diff/1/cc/animation/layer_animation...
cc/animation/layer_animation_controller.cc:369: bool notify_pending_observers =
true;
On 2014/08/05 13:05:57, ajuma wrote:
> These variables act as a form of documentation allowing someone reading this
> code to understand what the 'true' arguments being passed below mean. So these
> should not be removed.

Done. Makes sense. Will keep that in mind for future changes.

[ajuma, 2014-08-05 14:31:55]

lgtm

[shreyas.g, 2014-08-05 14:32:19]

The CQ bit was checked by shreyas.g@samsung.com

[commit-bot: I haz the power, 2014-08-05 14:33:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shreyas.g@samsung.com/441913002/20001

[commit-bot: I haz the power, 2014-08-05 17:09:25]

Change committed as 287554