Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: chrome/browser/content_settings/permission_queue_controller.cc

Issue 441883003: Simplify Android geolocation permission checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_queue_controller.cc
diff --git a/chrome/browser/content_settings/permission_queue_controller.cc b/chrome/browser/content_settings/permission_queue_controller.cc
index bd97b776b13eb31516d6fc2d3ac2866d8d326d96..c32e9d941750af14be685997e4efef9853769b76 100644
--- a/chrome/browser/content_settings/permission_queue_controller.cc
+++ b/chrome/browser/content_settings/permission_queue_controller.cc
@@ -46,7 +46,6 @@ class PermissionQueueController::PendingInfobarRequest {
const PermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
- const std::string& accept_button_label,
PermissionDecidedCallback callback);
~PendingInfobarRequest();
@@ -67,7 +66,6 @@ class PermissionQueueController::PendingInfobarRequest {
PermissionRequestID id_;
GURL requesting_frame_;
GURL embedder_;
- std::string accept_button_label_;
PermissionDecidedCallback callback_;
infobars::InfoBar* infobar_;
@@ -79,13 +77,11 @@ PermissionQueueController::PendingInfobarRequest::PendingInfobarRequest(
const PermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
- const std::string& accept_button_label,
PermissionDecidedCallback callback)
: type_(type),
id_(id),
requesting_frame_(requesting_frame),
embedder_(embedder),
- accept_button_label_(accept_button_label),
callback_(callback),
infobar_(NULL) {
}
@@ -111,7 +107,7 @@ void PermissionQueueController::PendingInfobarRequest::CreateInfoBar(
case CONTENT_SETTINGS_TYPE_GEOLOCATION:
infobar_ = GeolocationInfoBarDelegate::Create(
GetInfoBarService(id_), controller, id_, requesting_frame_,
- display_languages, accept_button_label_);
+ display_languages);
break;
#if defined(ENABLE_NOTIFICATIONS)
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
@@ -162,7 +158,6 @@ void PermissionQueueController::CreateInfoBarRequest(
const PermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
- const std::string& accept_button_label,
PermissionDecidedCallback callback) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
@@ -171,8 +166,7 @@ void PermissionQueueController::CreateInfoBarRequest(
return;
pending_infobar_requests_.push_back(PendingInfobarRequest(
- type_, id, requesting_frame, embedder,
- accept_button_label, callback));
+ type_, id, requesting_frame, embedder, callback));
if (!AlreadyShowingInfoBarForTab(id))
ShowQueuedInfoBarForTab(id);
}

Powered by Google App Engine
This is Rietveld 408576698