chrome/browser/content_settings/permission_queue_controller_unittest.cc - Issue 441883003: Simplify Android geolocation permission checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_queue_controller_unittest.cc

Issue 441883003: Simplify Android geolocation permission checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bernhard review, fix tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/mock_google_location_settings_helper.h ('K') | « chrome/browser/content_settings/permission_queue_controller.cc ('k') | chrome/browser/geolocation/geolocation_infobar_delegate.h » ('j') | chrome/browser/geolocation/geolocation_infobar_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_queue_controller_unittest.cc

diff --git a/chrome/browser/content_settings/permission_queue_controller_unittest.cc b/chrome/browser/content_settings/permission_queue_controller_unittest.cc

index d1ca0e70d8c17e192e125018353561933a49391e..2ff6c8970fb2bf996617906de717b82ece897910 100644

--- a/chrome/browser/content_settings/permission_queue_controller_unittest.cc

+++ b/chrome/browser/content_settings/permission_queue_controller_unittest.cc

@@ -97,9 +97,9 @@ TEST_F(PermissionQueueControllerTests, OneObservationPerInfoBarCancelled) {

GURL url("http://www.example.com/geolocation");

base::Callback<void(bool)> callback;

queue_controller.CreateInfoBarRequest(

- RequestID(0), url, url, "Accept", callback);

+ RequestID(0), url, url, callback);

queue_controller.CreateInfoBarRequest(

- RequestID(1), url, url, "Accept", callback);

+ RequestID(1), url, url, callback);

queue_controller.CancelInfoBarRequest(RequestID(0));

EXPECT_EQ(1, queue_controller.call_count());

};

@@ -109,7 +109,7 @@ TEST_F(PermissionQueueControllerTests, FailOnBadPattern) {

GURL url("chrome://settings");

base::Callback<void(bool)> callback;

queue_controller.CreateInfoBarRequest(

- RequestID(0), url, url, "Accept", callback);

+ RequestID(0), url, url, callback);

queue_controller.CancelInfoBarRequest(RequestID(0));

EXPECT_EQ(0, queue_controller.call_count());

};