chrome/android/shell/chrome_shell_google_location_settings_helper.h - Issue 441883003: Simplify Android geolocation permission checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/chrome_shell_google_location_settings_helper.h

Issue 441883003: Simplify Android geolocation permission checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bernhard review, fix tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/shell/chrome_shell_google_location_settings_helper.cc » ('j') | chrome/browser/android/mock_google_location_settings_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/chrome_shell_google_location_settings_helper.h

diff --git a/chrome/android/shell/chrome_shell_google_location_settings_helper.h b/chrome/android/shell/chrome_shell_google_location_settings_helper.h

index a4fd2c9d272b1125f47b4b369d3bd0f953ee715a..e8cd206df74658006331c0a721378ef54a211e9c 100644

--- a/chrome/android/shell/chrome_shell_google_location_settings_helper.h

+++ b/chrome/android/shell/chrome_shell_google_location_settings_helper.h

@@ -12,11 +12,7 @@ class ChromeShellGoogleLocationSettingsHelper

: public GoogleLocationSettingsHelper {

public:

// GoogleLocationSettingsHelper implementation:

- virtual std::string GetAcceptButtonLabel(bool allow) OVERRIDE;

- virtual void ShowGoogleLocationSettings() OVERRIDE;

- virtual bool IsMasterLocationSettingEnabled() OVERRIDE;

- virtual bool IsGoogleAppsLocationSettingEnabled() OVERRIDE;

- virtual bool IsAllowLabel() OVERRIDE;

+ virtual bool IsSystemLocationEnabled() OVERRIDE;

protected:

ChromeShellGoogleLocationSettingsHelper();