chrome/android/shell/chrome_shell_google_location_settings_helper.cc - Issue 441883003: Simplify Android geolocation permission checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/chrome_shell_google_location_settings_helper.cc

Issue 441883003: Simplify Android geolocation permission checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/shell/chrome_shell_google_location_settings_helper.h ('k') | chrome/browser/android/google_location_settings_helper.h » ('j') | chrome/browser/geolocation/geolocation_permission_context_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/chrome_shell_google_location_settings_helper.cc

diff --git a/chrome/android/shell/chrome_shell_google_location_settings_helper.cc b/chrome/android/shell/chrome_shell_google_location_settings_helper.cc

index 41aa232673a0229a1bd21672cf5d1d7f4e7d5ca2..a889c6c907b797365a65e53eb854439d27fc988b 100644

--- a/chrome/android/shell/chrome_shell_google_location_settings_helper.cc

+++ b/chrome/android/shell/chrome_shell_google_location_settings_helper.cc

@@ -18,14 +18,6 @@ ChromeShellGoogleLocationSettingsHelper::

~ChromeShellGoogleLocationSettingsHelper() {

}

-std::string ChromeShellGoogleLocationSettingsHelper::GetAcceptButtonLabel(

- bool allow) {

- return "Allow";

-void ChromeShellGoogleLocationSettingsHelper::ShowGoogleLocationSettings() {

bool ChromeShellGoogleLocationSettingsHelper::

IsGoogleAppsLocationSettingEnabled() {

return true;

@@ -34,7 +26,3 @@ bool ChromeShellGoogleLocationSettingsHelper::

bool ChromeShellGoogleLocationSettingsHelper::IsMasterLocationSettingEnabled() {

return true;

}

-bool ChromeShellGoogleLocationSettingsHelper::IsAllowLabel() {

- return true;