Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: chrome/browser/android/google_location_settings_helper.h

Issue 441883003: Simplify Android geolocation permission checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_
6 #define CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_ 6 #define CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_
7 7
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 // This class is needed to fetch the current system location 10 // This class is needed to fetch the current system location
11 // setting and update the infobar button label based on that information i.e, 11 // setting and update the infobar button label based on that information i.e,
12 // display "Allow" if google apps setting is set as enabled else, display 12 // display "Allow" if google apps setting is set as enabled else, display
13 // "Settings" with a link to open the system location settings activity. 13 // "Settings" with a link to open the system location settings activity.
14 class GoogleLocationSettingsHelper { 14 class GoogleLocationSettingsHelper {
15 public: 15 public:
16 virtual ~GoogleLocationSettingsHelper() {} 16 virtual ~GoogleLocationSettingsHelper() {}
17 17
18 static GoogleLocationSettingsHelper* Create(); 18 static GoogleLocationSettingsHelper* Create();
19 19
20 virtual std::string GetAcceptButtonLabel(bool allow) = 0;
21 virtual void ShowGoogleLocationSettings() = 0;
22 // Checks both Master and Google Apps location setting to see 20 // Checks both Master and Google Apps location setting to see
23 // if we should use "Allow" in the accept button. 21 // if we should use "Allow" in the accept button.
24 virtual bool IsAllowLabel() = 0;
25 virtual bool IsMasterLocationSettingEnabled() = 0; 22 virtual bool IsMasterLocationSettingEnabled() = 0;
26 virtual bool IsGoogleAppsLocationSettingEnabled() = 0; 23 virtual bool IsGoogleAppsLocationSettingEnabled() = 0;
27 24
28 protected: 25 protected:
29 GoogleLocationSettingsHelper() {} 26 GoogleLocationSettingsHelper() {}
30 27
28 // TODO(miguelg) Remove these three methods once the downstream
29 // dependencies get updated.
30 virtual std::string GetAcceptButtonLabel(bool allow);
31 virtual bool IsAllowLabel();
32 virtual void ShowGoogleLocationSettings();
33
31 private: 34 private:
32 35
33 DISALLOW_COPY_AND_ASSIGN(GoogleLocationSettingsHelper); 36 DISALLOW_COPY_AND_ASSIGN(GoogleLocationSettingsHelper);
34 }; 37 };
35 38
36 #endif // CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_ 39 #endif // CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698