Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: tools/telemetry/telemetry/timeline/importer.py

Issue 441873007: Move timeline and importers to use telemetry.value.TraceValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/timeline/importer.py
diff --git a/tools/telemetry/telemetry/timeline/importer.py b/tools/telemetry/telemetry/timeline/importer.py
index c2eca7574bb724dbf5521ad99c4d5e7e8cec4b4e..52ca2b5dfd515fffd61f55807d29c985bf8d74ad 100644
--- a/tools/telemetry/telemetry/timeline/importer.py
+++ b/tools/telemetry/telemetry/timeline/importer.py
@@ -2,18 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+from telemetry.value import trace as trace_value_module
+
class TimelineImporter(object):
- """Interface for classes that can add events to
- a timeline model from an TimelineData."""
- def __init__(self, model, timeline_data, import_priority=0):
+ """Reads TracedValue and populates timeline model with what it finds."""
nednguyen 2014/08/05 14:34:34 nit: TraceValue
+ def __init__(self, model, trace_value, import_order):
self._model = model
- self._timeline_data = timeline_data
- self.import_priority = import_priority
+ self.import_order = import_order
@staticmethod
- def CanImport(event_data_wrapper):
- """Returns true if the importer can process the given event data in the
- wrapper."""
+ def GetSupportedPart():
raise NotImplementedError
def ImportEvents(self):

Powered by Google App Engine
This is Rietveld 408576698