tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py - Issue 441873007: Move timeline and importers to use telemetry.value.TraceValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

Issue 441873007: Move timeline and importers to use telemetry.value.TraceValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py ('k') | tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py » ('j') | tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

index 7784884da06859480af6c152bc518237d75223df..3187cc170c97b5f75304fd9bae177633484b4209 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

@@ -10,6 +10,7 @@ import zipfile

from telemetry.core import util

from telemetry.core.backends.chrome import android_browser_finder

from telemetry.core.platform import profiler

+from telemetry.value import trace as trace_value_module

_SYSTRACE_CATEGORIES = [

'gfx',

@@ -52,7 +53,10 @@ class AndroidSystraceProfiler(profiler.Profiler):

def CollectProfile(self):

self._profiler.communicate(input='\n')

- trace_result = self._browser_backend.StopTracing()

+ trace_result_builder = trace_value_module.TraceValueBuilder()

+ self._browser_backend.StopTracing(builder)

slamm 2014/08/12 23:11:59 builder -> trace_result_builder ?

+ trace_result = trace_result_builder.AsValue()

trace_file = StringIO.StringIO()

trace_result.Serialize(trace_file)