App list: Infrastructure now supports multiple custom launcher pages.

App list: Infrastructure now supports multiple custom launcher pages.

AppListTestViewDelegate::CreateCustomPageWebViews now returns a vector
of views, not a single view. AppListViewDelegate is now able to generate
multiple custom launcher pages which will all be inserted into the
launcher (but currently only ever produces a single one, from the
--custom-launcher-page switch).

BUG=399131
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288975

[Matt Giuca, 2014-08-05 07:53:28]

derat@chromium.org: Please review changes in ash/shell/app_list.cc.

mukai@chromium.org: Please review changes in
athena/home/app_list_view_delegate.h.

calamity@chromium.org: Please review changes in chrome/browser/ui/app_list/* and
ui/app_list/*.

[Daniel Erat, 2014-08-05 16:12:20]

lgtm for ash/shell/app_list.cc

[Jun Mukai, 2014-08-05 22:48:03]

athena lgtm

[calamity, 2014-08-11 05:35:27]

https://codereview.chromium.org/441873004/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/app_list_view_delegate.cc (right):

https://codereview.chromium.org/441873004/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/app_list_view_delegate.cc:180: std::string
extension_id = id->host();
it->host()?

https://codereview.chromium.org/441873004/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/app_list_view_delegate.cc:183:
scoped_ptr<apps::AppDelegate>(new ChromeAppDelegate), extension_id);
What happens if this extension_id is invalid?

[Matt Giuca, 2014-08-11 06:14:05]

https://codereview.chromium.org/441873004/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/app_list_view_delegate.cc (right):

https://codereview.chromium.org/441873004/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/app_list_view_delegate.cc:180: std::string
extension_id = id->host();
On 2014/08/11 05:35:26, calamity wrote:
> it->host()?

Done.

https://codereview.chromium.org/441873004/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/app_list_view_delegate.cc:183:
scoped_ptr<apps::AppDelegate>(new ChromeAppDelegate), extension_id);
It has some potentially deep consequences but nothing bad currently happens --
AppWebContentsHelper.GetExtension() will return NULL (which is checked for in
all call sites).

[calamity, 2014-08-12 01:02:25]

lgtm.

[Matt Giuca, 2014-08-12 04:01:20]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-12 04:02:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/441873004/40001

[commit-bot: I haz the power, 2014-08-12 07:44:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-12 15:19:03]

Change committed as 288975