cc: Make sure mask and replica layers get DidBecomeActive signal.

cc: Make sure mask and replica layers get DidBecomeActive signal.

Since we create and rasterize mask and replica layer tiles as well,
we need to ensure that they get the DidBecomeActive signal in order
to ensure the tile priorities of the contained tiles are correct.
(DidBecomeActive switches active and pending priorities and clears
the pending priority). Without this, there are cases where the pending
priority can remain high without any mechanism clearing it.

BUG=400560
R=enne

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287693

[vmpstr, 2014-08-05 01:43:44]

PTAL. I kind of followed the pattern we have for UpdateTiles here. Aside from
updating the layer, we also update mask_layer and replica_layer->mask_layer.

[danakj, 2014-08-05 13:24:48]

Thanks. Can has test?

[vmpstr, 2014-08-05 16:51:03]

On 2014/08/05 13:24:48, danakj wrote:
> Thanks. Can has test?

PTAL. Added a test that fails without this patch and passes with.

[enne (OOO), 2014-08-05 17:09:58]

Mask and replica layers, always a bug factory.

lgtm

[danakj, 2014-08-05 17:16:48]

Thanks! LGTM2

https://codereview.chromium.org/441863002/diff/30001/cc/test/fake_picture_lay...
File cc/test/fake_picture_layer_impl.h (right):

https://codereview.chromium.org/441863002/diff/30001/cc/test/fake_picture_lay...
cc/test/fake_picture_layer_impl.h:45: size_t get_did_become_active_call_count()
{
inline accessor methods should match the variable name (no get_)

[vmpstr, 2014-08-05 18:54:34]

https://codereview.chromium.org/441863002/diff/30001/cc/test/fake_picture_lay...
File cc/test/fake_picture_layer_impl.h (right):

https://codereview.chromium.org/441863002/diff/30001/cc/test/fake_picture_lay...
cc/test/fake_picture_layer_impl.h:45: size_t get_did_become_active_call_count()
{
On 2014/08/05 17:16:47, danakj wrote:
> inline accessor methods should match the variable name (no get_)

Done.

[vmpstr, 2014-08-05 18:54:36]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-08-05 18:55:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/441863002/50001

[commit-bot: I haz the power, 2014-08-06 05:58:29]

Change committed as 287693