Range.surroundContents should throw InvalidStateError if a non-Text node is partially contained

InvalidStateError should be thrown firstly in Range.surroundContents

SPEC: http://dom.spec.whatwg.org/#dom-range-surroundcontents

According to spec, 'If a non-Text node is partially contained in the context object, throw an "InvalidStateError" exception.' is first step.
So this CL moved existed implementation to the first code block in function.

72 test cases will be passed with this CL in
http://w3c-test.org/dom/ranges/Range-surroundContents.html

Behavior in other browsers.
*)FF: PASS
*)IE: FAIL

TEST=LayoutTests/fast/dom/Range/surroundContents-for-invalid-state-error.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179795

[kangil_, 2014-08-05 06:25:00]

PTAL

fyi, trybot seems not working well at this moment.

[haraken, 2014-08-05 06:34:10]

The change to core/ looks good, but yutak-san wants to take a look.

https://codereview.chromium.org/441853003/diff/1/LayoutTests/fast/dom/Range/s...
File LayoutTests/fast/dom/Range/surroundContents-for-invalid-state-error.html
(right):

https://codereview.chromium.org/441853003/diff/1/LayoutTests/fast/dom/Range/s...
LayoutTests/fast/dom/Range/surroundContents-for-invalid-state-error.html:20:
document.getElementById('test').outerHTML = '';

What is this code for?

[kangil_, 2014-08-05 06:49:58]

https://codereview.chromium.org/441853003/diff/1/LayoutTests/fast/dom/Range/s...
File LayoutTests/fast/dom/Range/surroundContents-for-invalid-state-error.html
(right):

https://codereview.chromium.org/441853003/diff/1/LayoutTests/fast/dom/Range/s...
LayoutTests/fast/dom/Range/surroundContents-for-invalid-state-error.html:20:
document.getElementById('test').outerHTML = '';
On 2014/08/05 06:34:10, haraken wrote:
> 
> What is this code for?

This will clean 'start' and 'end' from the result.

[kangil_, 2014-08-07 12:32:26]

@yutak: PTAL :)

[Yuta Kitamura, 2014-08-08 04:49:31]

I'm mildly confused by the change description. This patch
just corrects the order of error checking, right? Your
change description is not sufficiently explaining that.

Please revise the change description so that people can
better understand what the patch is actually trying to do.

The change itself looks good.

https://codereview.chromium.org/441853003/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/441853003/diff/1/Source/core/dom/Range.cpp#ne...
Source/core/dom/Range.cpp:1211: // BAD_BOUNDARYPOINTS_ERR: Raised if the Range
partially selects a non-Text node.
BAD_BOUNDARYPOINTS_ERR is a completely wrong documentation
(I think it's the exception type which we previously threw).
Let's replace it with "InvalidStateError".

[kangil_, 2014-08-08 05:04:48]

PTAL

https://codereview.chromium.org/441853003/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/441853003/diff/1/Source/core/dom/Range.cpp#ne...
Source/core/dom/Range.cpp:1211: // BAD_BOUNDARYPOINTS_ERR: Raised if the Range
partially selects a non-Text node.
On 2014/08/08 04:49:31, Yuta Kitamura wrote:
> BAD_BOUNDARYPOINTS_ERR is a completely wrong documentation
> (I think it's the exception type which we previously threw).
> Let's replace it with "InvalidStateError".

Done.

[Yuta Kitamura, 2014-08-08 05:38:48]

lgtm

[kangil_, 2014-08-08 05:40:59]

The CQ bit was checked by kangil.han@samsung.com

[commit-bot: I haz the power, 2014-08-08 05:41:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kangil.han@samsung.com/441853003/20001

[commit-bot: I haz the power, 2014-08-08 07:09:03]

Change committed as 179795