mojo: first take on removing mojo_main_{chromium,standalone}.

mojo/services/view_manager/main.cc

Index: mojo/services/view_manager/main.cc
diff --git a/mojo/services/view_manager/main.cc b/mojo/services/view_manager/main.cc
index 9f6285ffe99004f083650de700cfc596909b8270..db2a281f09c568e736deb54efdd2b6c0e513f10d 100644
--- a/mojo/services/view_manager/main.cc
+++ b/mojo/services/view_manager/main.cc
@@ -4,6 +4,8 @@
 
 #include "mojo/public/cpp/application/application_connection.h"
 #include "mojo/public/cpp/application/application_delegate.h"
+#include "mojo/public/cpp/application/application_export.h"
+#include "mojo/public/cpp/application/application_runner_chromium.h"
 #include "mojo/services/view_manager/view_manager_init_service_context.h"
 #include "mojo/services/view_manager/view_manager_init_service_impl.h"
 
@@ -39,10 +41,10 @@ class ViewManagerApp : public ApplicationDelegate,
 };
 
 }  // namespace service
+}  // namespace mojo
 
-// static
-ApplicationDelegate* ApplicationDelegate::Create() {
-  return new mojo::service::ViewManagerApp();
+extern "C" APPLICATION_EXPORT MojoResult CDECL MojoMain(
+    MojoHandle shell_handle) {
+  return mojo::ApplicationRunnerChromium(make_scoped_delegate(
+      new mojo::service::ViewManagerApp)).Run(shell_handle);

[DaveMoore, 2014/08/08 22:27:17]

Even if it saves a line I think this should read like this:

  mojo::ApplicationRunnerChromium runner(make_scoped_ptr(
      new mojo::LauncherApp));
  return runner.Run(shell_handle);

The Run() call is important and with what you have it gets buried. This of
course goes for all the uses.

In fact after seeing so many calls to make_scoped_delegate I think I would get
rid of it, make the api just take an ApplicationDelegate* and decide if it
outlives the Runner like this:

  mojo::service::ViewManagerApp app;
  return mojo::ApplicationRunnerChromium(&app).Run(shell_handle);

or is deleted by it:

  mojo::service::ViewManagerApp* app = new mojo::service::ViewManagerApp;
  return mojo::ApplicationRunnerChromium(app).Run(shell_handle);

[tim (not reviewing), 2014/08/08 22:59:52]

The Runner will always own, delete, and outlive the delegate. If we were to make
it a raw pointer, it would be a bug to use it after Run(). The self-documenting
convention used in chrome for this is passing a scoped_ptr. I was tempted to
remove it too, but then I always am because it's always extra characters... :/ 
I figure it's better to just follow the rule, but if you insist we can kill it.

The alternative I proposed earlier to allow the delegate outlive the runner was
to add an ApplicationDelegate::Shutdown and use it as the analog to
Initialize(). We might wind up doing that anyway, but even if we did I (so far)
don't see a reason to allow the delegate to outlive the runner.

 }
-
-}  // namespace mojo