ash/frame/default_header_painter_unittest.cc - Issue 441803004: Introduce new WebApp header style for hosted apps and fizzy apps on ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/frame/default_header_painter_unittest.cc

Issue 441803004: Introduce new WebApp header style for hosted apps and fizzy apps on ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/frame/default_header_painter.cc ('K') | « ash/frame/default_header_painter.cc ('k') | ash/frame/header_painter.h » ('j') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/frame/default_header_painter_unittest.cc

diff --git a/ash/frame/default_header_painter_unittest.cc b/ash/frame/default_header_painter_unittest.cc

index 282baabb20c5c724eddcc22b4ebaa526f20e5a60..f0a6393c279c404f8831cd034b50714167494171 100644

--- a/ash/frame/default_header_painter_unittest.cc

+++ b/ash/frame/default_header_painter_unittest.cc

@@ -5,6 +5,7 @@

#include "ash/frame/default_header_painter.h"

#include "ash/frame/caption_buttons/frame_caption_button_container_view.h"

+#include "ash/frame/header_painter_util.h"

#include "ash/shell.h"

#include "ash/test/ash_test_base.h"

#include "ash/wm/window_state.h"

@@ -46,8 +47,9 @@ TEST_F(DefaultHeaderPainterTest, TitleIconAlignment) {

DefaultHeaderPainter painter;

painter.Init(w.get(),

w->non_client_view()->frame_view(),

- &window_icon,

&container);

+ painter.UpdateLeftHeaderView(&window_icon,

+ HeaderPainterUtil::GetDefaultIconSize());

painter.LayoutHeader();

gfx::Rect title_bounds = painter.GetTitleBounds();

EXPECT_EQ(window_icon.bounds().CenterPoint().y(),