Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: ash/frame/default_header_painter_unittest.cc

Issue 441803004: Introduce new WebApp header style for hosted apps and fizzy apps on ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Real assets, crushed, review feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/frame/default_header_painter.h" 5 #include "ash/frame/default_header_painter.h"
6 6
7 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h" 7 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h"
8 #include "ash/frame/header_painter_util.h"
pkotwicz 2014/08/19 00:17:07 This include is unnecessary. Remove it
benwells 2014/08/19 01:42:42 Done.
8 #include "ash/shell.h" 9 #include "ash/shell.h"
9 #include "ash/test/ash_test_base.h" 10 #include "ash/test/ash_test_base.h"
10 #include "ash/wm/window_state.h" 11 #include "ash/wm/window_state.h"
11 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
12 #include "grit/ash_resources.h" 13 #include "grit/ash_resources.h"
13 #include "ui/gfx/font_list.h" 14 #include "ui/gfx/font_list.h"
15 #include "ui/views/test/test_views.h"
14 #include "ui/views/widget/widget.h" 16 #include "ui/views/widget/widget.h"
15 #include "ui/views/window/non_client_view.h" 17 #include "ui/views/window/non_client_view.h"
16 18
17 using ash::HeaderPainter; 19 using ash::HeaderPainter;
18 using views::NonClientFrameView; 20 using views::NonClientFrameView;
19 using views::Widget; 21 using views::Widget;
20 22
21 namespace ash { 23 namespace ash {
22 24
23 class DefaultHeaderPainterTest : public ash::test::AshTestBase { 25 class DefaultHeaderPainterTest : public ash::test::AshTestBase {
24 public: 26 public:
25 // Creates a test widget that owns its native widget. 27 // Creates a test widget that owns its native widget.
26 Widget* CreateTestWidget() { 28 Widget* CreateTestWidget() {
27 Widget* widget = new Widget; 29 Widget* widget = new Widget;
28 Widget::InitParams params; 30 Widget::InitParams params;
29 params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 31 params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
30 params.context = CurrentContext(); 32 params.context = CurrentContext();
31 widget->Init(params); 33 widget->Init(params);
32 return widget; 34 return widget;
33 } 35 }
34 }; 36 };
35 37
36 // Ensure the title text is vertically aligned with the window icon. 38 // Ensure the title text is vertically aligned with the window icon.
37 TEST_F(DefaultHeaderPainterTest, TitleIconAlignment) { 39 TEST_F(DefaultHeaderPainterTest, TitleIconAlignment) {
38 scoped_ptr<Widget> w(CreateTestWidget()); 40 scoped_ptr<Widget> w(CreateTestWidget());
39 ash::FrameCaptionButtonContainerView container(w.get(), 41 ash::FrameCaptionButtonContainerView container(w.get(),
40 ash::FrameCaptionButtonContainerView::MINIMIZE_ALLOWED); 42 ash::FrameCaptionButtonContainerView::MINIMIZE_ALLOWED);
41 views::View window_icon; 43 views::StaticSizedView window_icon(gfx::Size(16, 16));
42 window_icon.SetBounds(0, 0, 16, 16); 44 window_icon.SetBounds(0, 0, 16, 16);
43 w->SetBounds(gfx::Rect(0, 0, 500, 500)); 45 w->SetBounds(gfx::Rect(0, 0, 500, 500));
44 w->Show(); 46 w->Show();
45 47
46 DefaultHeaderPainter painter; 48 DefaultHeaderPainter painter;
47 painter.Init(w.get(), 49 painter.Init(w.get(),
48 w->non_client_view()->frame_view(), 50 w->non_client_view()->frame_view(),
49 &window_icon,
50 &container); 51 &container);
52 painter.UpdateLeftHeaderView(&window_icon);
51 painter.LayoutHeader(); 53 painter.LayoutHeader();
52 gfx::Rect title_bounds = painter.GetTitleBounds(); 54 gfx::Rect title_bounds = painter.GetTitleBounds();
53 EXPECT_EQ(window_icon.bounds().CenterPoint().y(), 55 EXPECT_EQ(window_icon.bounds().CenterPoint().y(),
54 title_bounds.CenterPoint().y()); 56 title_bounds.CenterPoint().y());
55 } 57 }
56 58
57 } // namespace ash 59 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698