Introduce new WebApp header style for hosted apps and fizzy apps on ash.

chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h"
 
 #include <algorithm>
 
 #include "ash/ash_switches.h"
+#include "ash/frame/caption_buttons/frame_caption_button.h"
 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h"
 #include "ash/frame/default_header_painter.h"
 #include "ash/frame/frame_border_hit_test_controller.h"
 #include "ash/frame/header_painter_util.h"
 #include "ash/shell.h"
 #include "base/command_line.h"
+#include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/themes/theme_properties.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 #include "chrome/browser/ui/views/frame/browser_header_painter_ash.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
+#include "chrome/browser/ui/views/frame/webapp_header_painter_ash.h"
 #include "chrome/browser/ui/views/profiles/avatar_label.h"
 #include "chrome/browser/ui/views/profiles/avatar_menu_button.h"
 #include "chrome/browser/ui/views/tab_icon_view.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/ash_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/aura/client/aura_constants.h"
@@ skipping 44 matching lines @@
 // BrowserNonClientFrameViewAsh, public:
 
 // static
 const char BrowserNonClientFrameViewAsh::kViewClassName[] =
     "BrowserNonClientFrameViewAsh";
 
 BrowserNonClientFrameViewAsh::BrowserNonClientFrameViewAsh(
     BrowserFrame* frame, BrowserView* browser_view)
     : BrowserNonClientFrameView(frame, browser_view),
       caption_button_container_(NULL),
+      webapp_back_button_(NULL),

[pkotwicz, 2014/08/06 21:36:49]

Nit: Rename to web_app_back_button_

[benwells, 2014/08/13 00:53:45]

Done.

       window_icon_(NULL),
       frame_border_hit_test_controller_(
           new ash::FrameBorderHitTestController(frame)) {
   ash::Shell::GetInstance()->AddShellObserver(this);
 }
 
 BrowserNonClientFrameViewAsh::~BrowserNonClientFrameViewAsh() {
   ash::Shell::GetInstance()->RemoveShellObserver(this);
+  chrome::RemoveCommandObserver(browser_view()->browser(), IDC_BACK, this);
 }
 
 void BrowserNonClientFrameViewAsh::Init() {
   caption_button_container_ = new ash::FrameCaptionButtonContainerView(frame(),
       ash::FrameCaptionButtonContainerView::MINIMIZE_ALLOWED);
   caption_button_container_->UpdateSizeButtonVisibility();
   AddChildView(caption_button_container_);
 
   // Initializing the TabIconView is expensive, so only do it if we need to.
   if (browser_view()->ShouldShowWindowIcon()) {
     window_icon_ = new TabIconView(this, NULL);
     window_icon_->set_is_light(true);
     AddChildView(window_icon_);
     window_icon_->Update();
   }
 
   // Create incognito icon if necessary.
   UpdateAvatarInfo();
 
   // HeaderPainter handles layout.
   if (UsePackagedAppHeaderStyle()) {
     ash::DefaultHeaderPainter* header_painter = new ash::DefaultHeaderPainter;
     header_painter_.reset(header_painter);
     header_painter->Init(frame(), this, window_icon_,
         caption_button_container_);
+  } else if (UseWebAppHeaderStyle()) {
+    webapp_back_button_ =
+        new ash::FrameCaptionButton(this, ash::CAPTION_BUTTON_ICON_BACK);
+    UpdateBackButtonState(false);

[pkotwicz, 2014/08/06 21:36:48]

The back button should be enabled by default. Otherwise, the back button is
never enabled for a streamlined app opened via session-restore

[benwells, 2014/08/13 00:53:45]

Done.

+    chrome::AddCommandObserver(browser_view()->browser(), IDC_BACK, this);
+    AddChildView(webapp_back_button_);
+
+    WebAppHeaderPainterAsh* header_painter = new WebAppHeaderPainterAsh;

[pkotwicz, 2014/08/06 21:36:48]

I would rather use DefaultHeaderPainter (as opposed to WebAppHeaderPainterAsh).
You can set |web_app_back_button_|'s images here too.

It is not an ideal solution, but I think that it is the least bad solution given
how little special logic is needed yet for streamlined apps.

[benwells, 2014/08/11 07:06:15]

Yeah there is currently little special logic. I'll send you mocks so you can see
where it is heading.

If I use the DefaultHeaderPainter, I don't think it will get the title bounds
correct. Are you suggesting I replace the window_icon field in
DefaultHeaderPainter with something like left_header_view_ and make it handle
both the back button or the window icon?

[benwells, 2014/08/13 00:53:45]

Done.

+    header_painter_.reset(header_painter);
+    header_painter->InitForWebApp(frame(), this, webapp_back_button_,
+        caption_button_container_);
   } else {
     BrowserHeaderPainterAsh* header_painter = new BrowserHeaderPainterAsh;
     header_painter_.reset(header_painter);
     header_painter->Init(frame(), browser_view(), this, window_icon_,
         caption_button_container_);
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserNonClientFrameView:
@@ skipping 20 matching lines @@
   if (!ShouldPaint() || UseImmersiveLightbarHeaderStyle())
     return 0;
 
   if (browser_view()->IsTabStripVisible()) {
     if (frame()->IsMaximized() || frame()->IsFullscreen())
       return kTabstripTopSpacingShort;
     else
       return kTabstripTopSpacingTall;
   }
 
-  if (UsePackagedAppHeaderStyle())
+  if (UsePackagedAppHeaderStyle() || UseWebAppHeaderStyle())
     return header_painter_->GetHeaderHeightForPainting();
 
   int caption_buttons_bottom = caption_button_container_->bounds().bottom();
 
   // The toolbar partially overlaps the caption buttons.
   if (browser_view()->IsToolbarVisible())
     return caption_buttons_bottom - kContentShadowHeight;
 
   return caption_buttons_bottom + kClientEdgeThickness;
 }
@@ skipping 24 matching lines @@
     const gfx::Rect& client_bounds) const {
   return client_bounds;
 }
 
 int BrowserNonClientFrameViewAsh::NonClientHitTest(const gfx::Point& point) {
   int hit_test = ash::FrameBorderHitTestController::NonClientHitTest(this,
       caption_button_container_, point);
 
   // See if the point is actually within the avatar menu button or within
   // the avatar label.
   if (hit_test == HTCAPTION && ((avatar_button() &&

[pkotwicz, 2014/08/06 21:36:49]

Nit: Something like this might be more readable.

if (hit_test == HTCAPTION &&
    (ConvertPointToViewAndHitTest(this, avatar_button(), point) ||
     ConvertPointToViewAndHitTest(this, web_app_back_button_, point)) {
  return HTCLIENT;
}

where ConvertPointToViewAndHitTest() needs to be written and would have to
handle the NULL case

I have ommitted avatar_label() on purpose because it is not used on CrOS (e.g.
it is not laid out in BrowserNonClientFrameViewAsh::Layout() )

[benwells, 2014/08/13 00:53:45]

Done.

        avatar_button()->GetMirroredBounds().Contains(point)) ||
       (avatar_label() && avatar_label()->GetMirroredBounds().Contains(point))))
       return HTCLIENT;
 
+  if (hit_test == HTCAPTION && webapp_back_button_ &&
+      webapp_back_button_->GetMirroredBounds().Contains(point))
+    return HTCLIENT;
+
   // When the window is restored we want a large click target above the tabs
   // to drag the window, so redirect clicks in the tab's shadow to caption.
   if (hit_test == HTCLIENT &&
       !(frame()->IsMaximized() || frame()->IsFullscreen())) {
     // Convert point to client coordinates.
     gfx::Point client_point(point);
     View::ConvertPointToTarget(this, frame()->client_view(), &client_point);
     // Report hits in shadow at top of tabstrip as caption.
     gfx::Rect tabstrip_bounds(browser_view()->tabstrip()->bounds());
     if (client_point.y() < tabstrip_bounds.y() + kTabShadowHeight)
@@ skipping 32 matching lines @@
 
 void BrowserNonClientFrameViewAsh::OnPaint(gfx::Canvas* canvas) {
   if (!ShouldPaint())
     return;
 
   if (UseImmersiveLightbarHeaderStyle()) {
     PaintImmersiveLightbarStyleHeader(canvas);
     return;
   }
 
   caption_button_container_->SetPaintAsActive(ShouldPaintAsActive());

[pkotwicz, 2014/08/06 21:36:48]

To be consistent, you also need to change the |web_app_back_button_|'s paint as
active state here

[benwells, 2014/08/13 00:53:45]

Done.

 
   ash::HeaderPainter::Mode header_mode = ShouldPaintAsActive() ?
       ash::HeaderPainter::MODE_ACTIVE : ash::HeaderPainter::MODE_INACTIVE;
   header_painter_->PaintHeader(canvas, header_mode);
   if (browser_view()->IsToolbarVisible())
     PaintToolbarBackground(canvas);
-  else if (!UsePackagedAppHeaderStyle())
+  else if (!UsePackagedAppHeaderStyle() && !UseWebAppHeaderStyle())
     PaintContentEdge(canvas);
 }
 
 void BrowserNonClientFrameViewAsh::Layout() {
   // The header must be laid out before computing |painted_height| because the
   // computation of |painted_height| for app and popup windows depends on the
   // position of the window controls.
   header_painter_->LayoutHeader();
 
   int painted_height = 0;
   if (browser_view()->IsTabStripVisible()) {
     painted_height = GetTopInset() +
         browser_view()->tabstrip()->GetPreferredSize().height();
   } else if (browser_view()->IsToolbarVisible()) {
     // Paint the header so that it overlaps with the top few pixels of the
     // toolbar because the top few pixels of the toolbar are not opaque.
     painted_height = GetTopInset() + kFrameShadowThickness * 2;
   } else {
     painted_height = GetTopInset();
   }
   header_painter_->SetHeaderHeightForPainting(painted_height);

[pkotwicz, 2014/08/06 21:36:48]

When both the multi-profile avatar and the back button are visible, the avatar
and the button overlap and the back button is not clickable.

To make the multi-profile avatar appear:
- You must have at least two profiles which show up in the login page
- Once logged in, click on the user name in the ash tray. It should give you the
option to "Sign in another account".
- Right click on the window header to move a streamlined app to another profile

I am unsure what the best solution is. What makes it hard is that LayoutAvatar()
depends on GetTopInset() having been computed which depends on
HeaderPainter::LayoutHeader() having been run.

Oshima, do you have any ideas?

[benwells, 2014/08/13 00:53:45]

OK, I'm now taking this into account. It feels a bit yuck. Let me know what you
think, I'm wondering if it would be better if DefaultHeaderPainter knew about
avatars in some way (like it knew about window icons / now knows about left
header views).

   if (avatar_button())
     LayoutAvatar();
   BrowserNonClientFrameView::Layout();
 }
 
 const char* BrowserNonClientFrameViewAsh::GetClassName() const {
   return kViewClassName;
 }
 
 void BrowserNonClientFrameViewAsh::GetAccessibleState(
@@ skipping 56 matching lines @@
 }
 
 gfx::ImageSkia BrowserNonClientFrameViewAsh::GetFaviconForTabIconView() {
   views::WidgetDelegate* delegate = frame()->widget_delegate();
   if (!delegate)
     return gfx::ImageSkia();
   return delegate->GetWindowIcon();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
+// CommandObserver:
+
+void BrowserNonClientFrameViewAsh::EnabledStateChangedForCommand(int id,
+                                                                 bool enabled) {
+  DCHECK_EQ(IDC_BACK, id);
+  UpdateBackButtonState(enabled);
+}
+
+///////////////////////////////////////////////////////////////////////////////
+// views::ButtonListener:
+
+void BrowserNonClientFrameViewAsh::ButtonPressed(views::Button* sender,
+                                                 const ui::Event& event) {
+  DCHECK_EQ(sender, webapp_back_button_);
+  chrome::ExecuteCommand(browser_view()->browser(), IDC_BACK);
+}
+
+///////////////////////////////////////////////////////////////////////////////
 // BrowserNonClientFrameViewAsh, private:
 
 // views::NonClientFrameView:
 bool BrowserNonClientFrameViewAsh::DoesIntersectRect(
     const views::View* target,
     const gfx::Rect& rect) const {
   CHECK_EQ(target, this);
   if (!views::ViewTargeterDelegate::DoesIntersectRect(this, rect)) {
     // |rect| is outside BrowserNonClientFrameViewAsh's bounds.
     return false;
@@ skipping 34 matching lines @@
   ImmersiveModeController* immersive_controller =
       browser_view()->immersive_mode_controller();
   return immersive_controller->IsEnabled() &&
       !immersive_controller->IsRevealed() &&
       browser_view()->IsTabStripVisible();
 }
 
 bool BrowserNonClientFrameViewAsh::UsePackagedAppHeaderStyle() const {
   // Non streamlined hosted apps do not have a toolbar or tabstrip. Their header
   // should look the same as the header for packaged apps. Streamlined hosted
-  // apps have a toolbar so should use the browser header style.
+  // apps have the experimental WebApp header style.

[pkotwicz, 2014/08/06 21:36:48]

Nit: Maybe change the return value to:
return browser_view()->browser()->is_app() && !UseWebAppHeaderStyle();

Doing this should enable you to remove the comment wrt to streamlined hosted
apps

[benwells, 2014/08/13 00:53:45]

Done.

   return browser_view()->browser()->is_app() &&
       !CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableStreamlinedHostedApps);
 }
 
+bool BrowserNonClientFrameViewAsh::UseWebAppHeaderStyle() const {
+  // Use of the experimental WebApp header style is guarded with the
+  // streamlined hosted app style.
+  return browser_view()->browser()->is_app() &&
+      CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableStreamlinedHostedApps);
+}
+
 void BrowserNonClientFrameViewAsh::LayoutAvatar() {
   DCHECK(avatar_button());
 #if !defined(OS_CHROMEOS)
   // ChromeOS shows avatar on V1 app.
   DCHECK(browser_view()->IsTabStripVisible());
 #endif
   gfx::ImageSkia incognito_icon = browser_view()->GetOTRAvatarIcon();
 
   int avatar_bottom = GetTopInset() +
       browser_view()->GetTabStripHeight() - kAvatarBottomSpacing;
@@ skipping 107 matching lines @@
   canvas->FillRect(
       gfx::Rect(x + kClientEdgeThickness,
                 toolbar_bounds.bottom() - kClientEdgeThickness,
                 w - (2 * kClientEdgeThickness),
                 kClientEdgeThickness),
       ThemeProperties::GetDefaultColor(
           ThemeProperties::COLOR_TOOLBAR_SEPARATOR));
 }
 
 void BrowserNonClientFrameViewAsh::PaintContentEdge(gfx::Canvas* canvas) {
-  DCHECK(!UsePackagedAppHeaderStyle());
+  DCHECK(!UsePackagedAppHeaderStyle() && !UseWebAppHeaderStyle());
   canvas->FillRect(gfx::Rect(0, caption_button_container_->bounds().bottom(),
                              width(), kClientEdgeThickness),
                    ThemeProperties::GetDefaultColor(
                        ThemeProperties::COLOR_TOOLBAR_SEPARATOR));
 }
+
+void BrowserNonClientFrameViewAsh::UpdateBackButtonState(bool enabled) {
+  webapp_back_button_->SetState(enabled ? views::Button::STATE_NORMAL
+                                        : views::Button::STATE_DISABLED);
+  webapp_back_button_->set_paint_as_active(enabled);
+}