Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 441783002: [Android] Update gtest test list parsing. (Closed)

Created:
6 years, 4 months ago by jbudorick
Modified:
6 years, 4 months ago
Reviewers:
klundberg, craigdh
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Update gtest test list parsing. Some versions of gtest print type- and value-parameterized tests with their respective parameter as a comment after the test name when listing tests. This patch should allow the android test runner scripts to correctly ignore these comments. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287548

Patch Set 1 #

Patch Set 2 : add chromium copyright header to test_package_test.py. #

Total comments: 1

Patch Set 3 : fix presubmit errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download
M build/android/pylib/gtest/test_package.py View 1 chunk +1 line, -1 line 0 comments Download
A build/android/pylib/gtest/test_package_test.py View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jbudorick
6 years, 4 months ago (2014-08-04 21:51:21 UTC) #1
craigdh
lgtm. https://codereview.chromium.org/441783002/diff/20001/build/android/pylib/gtest/test_package.py File build/android/pylib/gtest/test_package.py (right): https://codereview.chromium.org/441783002/diff/20001/build/android/pylib/gtest/test_package.py#newcode99 build/android/pylib/gtest/test_package.py:99: test_name = test.split(None, 1)[0] isn't this equivalent to ...
6 years, 4 months ago (2014-08-04 22:00:13 UTC) #2
jbudorick
On 2014/08/04 22:00:13, craigdh wrote: > lgtm. > > https://codereview.chromium.org/441783002/diff/20001/build/android/pylib/gtest/test_package.py > File build/android/pylib/gtest/test_package.py (right): > ...
6 years, 4 months ago (2014-08-04 22:03:43 UTC) #3
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-04 22:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/441783002/20001
6 years, 4 months ago (2014-08-04 22:58:41 UTC) #5
jbudorick
The CQ bit was unchecked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-04 23:39:21 UTC) #6
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-05 13:48:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/441783002/40001
6 years, 4 months ago (2014-08-05 13:50:07 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 16:05:18 UTC) #9
Message was sent while issue was closed. 
Change committed as 287548

Powered by Google App Engine
This is Rietveld 408576698