Remove unused |m_pEvi| field.

fpdfsdk/src/fsdk_actionhandler.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../include/fsdk_define.h"
 #include "../include/fsdk_mgr.h"
 #include "../include/fsdk_actionhandler.h"
 #include "../include/javascript/IJavaScript.h"
 
 /* -------------------------- CBA_ActionHandler -------------------------- */
 
 CPDFSDK_ActionHandler::CPDFSDK_ActionHandler(CPDFDoc_Environment* pEvi) : 
-        m_pEvi(pEvi),
         m_pFormActionHandler(NULL),
         m_pMediaActionHandler(NULL)
 {
                 m_pFormActionHandler = new CPDFSDK_FormActionHandler;
 }
 
 CPDFSDK_ActionHandler::~CPDFSDK_ActionHandler()
 {
         if(m_pFormActionHandler)
         {
@@ skipping 236 matching lines @@
         {
                 CPDF_Action subaction = action.GetSubAction(i);
                 if (!ExecuteDocumentPageAction(subaction, type, pDocument,/* pDocView,*/ list)) return FALSE;
         }
 
         return TRUE;
 }
 
 FX_BOOL CPDFSDK_ActionHandler::IsValidField(CPDFSDK_Document* pDocument, CPDF_Dictionary* pFieldDict)
 {
-        ASSERT(m_pEvi != NULL);
         ASSERT(pDocument != NULL);
         ASSERT(pFieldDict != NULL);
 
         if (1/*m_pApp->IsValidDocument(pDocument)*/)

[Nico, 2014/08/04 20:54:21]

O_o

[palmer, 2014/08/04 21:10:51]

Say, Bo, what was intended here? This is the only instance of the name
|IsValidDocument| in the source tree. Was it once defined as a meaningful
function...?

[Bo Xu, 2014/08/04 21:18:38]

I do not have the dev for this file here but I guess you are right. Some codes
were chopped and this maybe one of them. And I agree we have some un-finalized
codes which should have been get rid of.

         {
                 CPDFSDK_InterForm* pInterForm = pDocument->GetInterForm();
                 ASSERT(pInterForm != NULL);
 
                 CPDF_InterForm* pPDFInterForm = pInterForm->GetInterForm();
                 ASSERT(pPDFInterForm != NULL);
 
                 return pPDFInterForm->GetFieldByDict(pFieldDict) != NULL;
         }
 
@@ skipping 554 matching lines @@
 FX_BOOL CPDFSDK_MediaActionHandler::DoAction_Sound(const CPDF_Action& action, CPDFSDK_Document* pDocument)
 {
         return FALSE;
 }
 
 FX_BOOL CPDFSDK_MediaActionHandler::DoAction_Movie(const CPDF_Action& action, CPDFSDK_Document* pDocument)
 {
         return FALSE;
 }