Remove unused |m_pEvi| field.

Remove unused |m_pEvi| field.

Edge closer to the goal of building PDFium with the chromium_code
configuration.

BUG=https://code.google.com/p/pdfium/issues/detail?id=29

[palmer, 2014-08-04 20:53:14]

Please take a look.

[Nico, 2014-08-04 20:54:21]

lgtm

https://codereview.chromium.org/441763002/diff/1/fpdfsdk/src/fsdk_actionhandl...
File fpdfsdk/src/fsdk_actionhandler.cpp (right):

https://codereview.chromium.org/441763002/diff/1/fpdfsdk/src/fsdk_actionhandl...
fpdfsdk/src/fsdk_actionhandler.cpp:274: if
(1/*m_pApp->IsValidDocument(pDocument)*/)
O_o

[palmer, 2014-08-04 21:10:51]

https://codereview.chromium.org/441763002/diff/1/fpdfsdk/src/fsdk_actionhandl...
File fpdfsdk/src/fsdk_actionhandler.cpp (right):

https://codereview.chromium.org/441763002/diff/1/fpdfsdk/src/fsdk_actionhandl...
fpdfsdk/src/fsdk_actionhandler.cpp:274: if
(1/*m_pApp->IsValidDocument(pDocument)*/)
Say, Bo, what was intended here? This is the only instance of the name
|IsValidDocument| in the source tree. Was it once defined as a meaningful
function...?

[Bo Xu, 2014-08-04 21:18:38]

https://codereview.chromium.org/441763002/diff/1/fpdfsdk/src/fsdk_actionhandl...
File fpdfsdk/src/fsdk_actionhandler.cpp (right):

https://codereview.chromium.org/441763002/diff/1/fpdfsdk/src/fsdk_actionhandl...
fpdfsdk/src/fsdk_actionhandler.cpp:274: if
(1/*m_pApp->IsValidDocument(pDocument)*/)
On 2014/08/04 21:10:51, Chromium Palmer wrote:
> Say, Bo, what was intended here? This is the only instance of the name
> |IsValidDocument| in the source tree. Was it once defined as a meaningful
> function...?

I do not have the dev for this file here but I guess you are right. Some codes
were chopped and this maybe one of them. And I agree we have some un-finalized
codes which should have been get rid of.

[Bo Xu, 2014-08-04 21:19:00]

lgtm

[palmer, 2014-08-04 21:29:59]

> I do not have the dev for this file here but I guess you are right. Some codes
> were chopped and this maybe one of them. And I agree we have some un-finalized
> codes which should have been get rid of.

So, nobody has the history for this? I can easily "fix" this code, but I'd
rather know if the |IsValidDocument| function was necessary and did meaningful
work at one time in the past.

[Bo Xu, 2014-08-04 21:32:41]

On 2014/08/04 21:29:59, Chromium Palmer wrote:
> > I do not have the dev for this file here but I guess you are right. Some
codes
> > were chopped and this maybe one of them. And I agree we have some
un-finalized
> > codes which should have been get rid of.
> 
> So, nobody has the history for this? I can easily "fix" this code, but I'd
> rather know if the |IsValidDocument| function was necessary and did meaningful
> work at one time in the past.

I will check engineers in China, they should know the answer. "here" I meant for
"US office" :0

[palmer, 2014-08-04 23:02:20]

This CL landed as
https://pdfium.googlesource.com/pdfium/+/7b99cd3306b669c120d8a581dadd9e480ba4...,
but this issue did not get updated for some reason. I got into some kind of
inconsistent state between "git cl land", "git pull", et c. :\

[Bo Xu, 2014-08-04 23:06:41]

On 2014/08/04 23:02:20, Chromium Palmer wrote:
> This CL landed as
>
https://pdfium.googlesource.com/pdfium/+/7b99cd3306b669c120d8a581dadd9e480ba4...,
> but this issue did not get updated for some reason. I got into some kind of
> inconsistent state between "git cl land", "git pull", et c. :\

git pull works for me for this commit on windows.

[palmer, 2014-08-19 22:30:38]

This CL has landed but something weird happened so it doesn't show up as closed
here. Closing manually.