Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2338)

Unified Diff: chrome/test/data/extensions/api_test/notification_provider/events/test.js

Issue 441753002: Route newly created notifications to notification provider API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments, deleted browser tests for onUpdated and onCleared Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/notification_provider/events/manifest.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/notification_provider/events/test.js
diff --git a/chrome/test/data/extensions/api_test/notification_provider/events/test.js b/chrome/test/data/extensions/api_test/notification_provider/events/test.js
index 215699db68f71df9265eb195dcb99ccb159258d0..d89fbe751c04355899ac2a6c1cabb0b27b503267 100644
--- a/chrome/test/data/extensions/api_test/notification_provider/events/test.js
+++ b/chrome/test/data/extensions/api_test/notification_provider/events/test.js
@@ -1,24 +1,30 @@
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-var testEvents = function() {
- chrome.notificationProvider.onCreated.addListener(function(senderId,
- notificationId,
- options) {
- chrome.test.succeed();
- });
+var idString = "id1";
+
+function testOnCreated() {
- chrome.notificationProvider.onUpdated.addListener(function(senderId,
+ var content = {
+ type: "basic",
+ iconUrl: "icon.png",
+ title: "Title",
+ message: "This is the message."
+ };
+
+ var createCallback = function (id) {}
+ chrome.notifications.create(idString, content, createCallback);
+
+ chrome.notificationProvider.onCreated.addListener(function(senderId,
notificationId,
options) {
- chrome.test.succeed();
- });
-
- chrome.notificationProvider.onCleared.addListener(function(senderId,
- notificationId) {
+ var str = notificationId.split("-");
+ chrome.test.assertEq(idString, str[1]);
+ chrome.test.assertEq(options.title, content.title);
+ chrome.test.assertEq(options.message, content.message);
chrome.test.succeed();
});
};
-chrome.test.runTests([ testEvents ]);
+chrome.test.runTests([ testOnCreated ]);
« no previous file with comments | « chrome/test/data/extensions/api_test/notification_provider/events/manifest.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698