Route newly created notifications to notification provider API.

chrome/browser/notifications/notification_conversion_helper.h

Index: chrome/browser/notifications/notification_conversion_helper.h
diff --git a/chrome/browser/notifications/notification_conversion_helper.h b/chrome/browser/notifications/notification_conversion_helper.h
new file mode 100644
index 0000000000000000000000000000000000000000..1e2439a9363aba4512277f7c3f37843dbe862936
--- /dev/null
+++ b/chrome/browser/notifications/notification_conversion_helper.h
@@ -0,0 +1,33 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_CONVERSION_HELPER_H_
+#define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_CONVERSION_HELPER_H_
+
+#include "base/values.h"

[dewittj, 2014/08/09 00:29:52]

We don't need all these include files.  You can remove line 8, 10, 11, and 12,
provided that you forward declare the NotificationOptions and NotificationBitmap
type.  Something like:

namespace extensions {
namespace api {
namespace notifications {
class NotificationOptions;
class NotificationBitmap;
}  // namespace notifications
}  // namespace api
}  // namespace extensions

namespace gfx {
class Image;
}

This will improve build times since the entire headers are not needed to compile
this header.  Note that you still need to include c/b/n/notification.h since the
type is referred to as a const ref, not just a pointer (in line 22.)

Removing these includes here may mean that you will now need to include them in
the cc file, which is better.

[liyanhou, 2014/08/11 17:21:10]

Done. I didn't know that. That's great. Thank you so much!

+#include "chrome/browser/notifications/notification.h"
+#include "chrome/common/extensions/api/notifications.h"
+#include "ui/gfx/image/image.h"
+#include "ui/gfx/image/image_skia.h"
+#include "ui/message_center/notification_types.h"
+
+class NotificationConversionHelper {

[dewittj, 2014/08/09 00:29:52]

Probably this class can just be a container for static functions.

[liyanhou, 2014/08/11 17:21:10]

Done.

+ public:
+  NotificationConversionHelper();
+
+  ~NotificationConversionHelper();
+
+  void NotificationToNotificationOptions(
+      const Notification& notification,
+      extensions::api::notifications::NotificationOptions* options);
+
+ private:
+  void GfxImageToNotificationBitmap(
+      const gfx::Image* gfx_image,
+      extensions::api::notifications::NotificationBitmap* return_image_args);
+
+  std::string MapTypeToString(message_center::NotificationType type);
+};
+
+#endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_CONVERSION_HELPER_H_