Make remote CALayers work with browser compositor on Mac

Make remote CALayers work with browser compositor on Mac

This adds the equivalent remote layer code from RenderWidgetHostViewMac
over to the BrowserCompositorViewMac.

This code still isn't activated yet -- backpressure is still not appropriately
applied via ImageTransportLayer.

BUG=312462
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287502

[ccameron, 2014-08-04 20:56:00]

Just moving a couple of things around. The only thing that (I know) is missing
is appropriate backpressure, which I'll be adding to ImageTransportSurface in
the next patch.

[Ken Russell (switch to Gerrit), 2014-08-05 02:03:21]

LGTM overall.

https://codereview.chromium.org/441743003/diff/20001/content/browser/composit...
File content/browser/compositor/browser_compositor_view_private_mac.mm (right):

https://codereview.chromium.org/441743003/diff/20001/content/browser/composit...
content/browser/compositor/browser_compositor_view_private_mac.mm:184: // in the
heirarchy.
typo: hierarchy

https://codereview.chromium.org/441743003/diff/20001/content/browser/composit...
content/browser/compositor/browser_compositor_view_private_mac.mm:188: // Remove
any different-type layers that this is replacing.
The naming convention's getting confusing here. Consider renaming
accelerated_layer_ to something like iosurface_layer_ and
accelerated_layer_host_ to remote_calayer_host_ or similar.

[ccameron, 2014-08-05 04:29:59]

Thanks!

https://codereview.chromium.org/441743003/diff/20001/content/browser/composit...
File content/browser/compositor/browser_compositor_view_private_mac.mm (right):

https://codereview.chromium.org/441743003/diff/20001/content/browser/composit...
content/browser/compositor/browser_compositor_view_private_mac.mm:184: // in the
heirarchy.
On 2014/08/05 02:03:21, Ken Russell wrote:
> typo: hierarchy

Done.

https://codereview.chromium.org/441743003/diff/20001/content/browser/composit...
content/browser/compositor/browser_compositor_view_private_mac.mm:188: // Remove
any different-type layers that this is replacing.
On 2014/08/05 02:03:21, Ken Russell wrote:
> The naming convention's getting confusing here. Consider renaming
> accelerated_layer_ to something like iosurface_layer_ and
> accelerated_layer_host_ to remote_calayer_host_ or similar.

You're right -- I was so excited to stop calling the IOSurface layer
"composited" (everything is composited) that I let this monstrosity grow here
and in some other places.

I've gone with io_surface_layer and ca_context_layer, to mirror the parts that
make sense.

[ccameron, 2014-08-05 04:30:03]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-08-05 04:32:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/441743003/40001

[commit-bot: I haz the power, 2014-08-05 05:43:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37364)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[ccameron, 2014-08-05 05:45:17]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-08-05 05:46:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/441743003/60001

[commit-bot: I haz the power, 2014-08-05 06:57:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37384)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[commit-bot: I haz the power, 2014-08-05 07:01:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 07:01:24]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[ccameron, 2014-08-05 07:16:47]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-08-05 07:17:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/441743003/80001

[commit-bot: I haz the power, 2014-08-05 09:18:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-05 09:40:33]

Change committed as 287502