Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 441713002: Use WaitForResizeComplete() instead of waiting for first paint. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use WaitForResizeComplete() instead of waiting for first paint. That should fix flakyness for the test on Windows with cl 134623005. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -60 lines) Patch
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M content/public/test/test_navigation_observer.h View 4 chunks +0 lines, -15 lines 0 comments Download
M content/public/test/test_navigation_observer.cc View 4 chunks +1 line, -37 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mlamouri (slow - plz ping)
The point of this CL is to fix the flakyness of screen_orientation_browsertest that is made ...
6 years, 4 months ago (2014-08-04 17:31:13 UTC) #1
mlamouri (slow - plz ping)
Moving review to jochen@ because jam@ is OOO.
6 years, 4 months ago (2014-08-04 17:50:40 UTC) #2
enne (OOO)
This appears to fix the Windows issues that I've seen when I ran it through ...
6 years, 4 months ago (2014-08-04 20:42:54 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-05 09:08:29 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-05 09:18:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/441713002/1
6 years, 4 months ago (2014-08-05 09:19:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 10:43:43 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 11:27:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1209)
6 years, 4 months ago (2014-08-05 11:27:24 UTC) #9
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-05 12:13:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/441713002/1
6 years, 4 months ago (2014-08-05 12:14:18 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 13:09:11 UTC) #12
Message was sent while issue was closed.
Change committed as 287526

Powered by Google App Engine
This is Rietveld 408576698