Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 441673003: Fix new[]/delete mismatch in AudioBusPerfTest. (Closed)

Created:
6 years, 4 months ago by scherkus (not reviewing)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix new[]/delete mismatch in AudioBusPerfTest. Discoved while running media_perftests on a local debug build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287429

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/base/audio_bus_perftest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scherkus (not reviewing)
6 years, 4 months ago (2014-08-04 18:22:34 UTC) #1
rileya (GONE FROM CHROMIUM)
LGTM
6 years, 4 months ago (2014-08-04 18:29:00 UTC) #2
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 4 months ago (2014-08-04 18:34:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/441673003/20001
6 years, 4 months ago (2014-08-04 18:37:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 22:32:19 UTC) #5
commit-bot: I haz the power
Change committed as 287429
6 years, 4 months ago (2014-08-05 01:09:10 UTC) #6
Lei Zhang
I actually reported this as bug 399849.
6 years, 4 months ago (2014-08-05 01:26:14 UTC) #7
scherkus (not reviewing)
6 years, 4 months ago (2014-08-05 01:31:52 UTC) #8
Message was sent while issue was closed.
On 2014/08/05 01:26:14, Lei Zhang wrote:
> I actually reported this as bug 399849.

Woah!

Thanks for filing :)

Powered by Google App Engine
This is Rietveld 408576698