Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 441643008: Track number of generic ICs per function (Closed)

Created:
6 years, 4 months ago by Jakob Kummerow
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Track number of generic ICs per function and use it to disable optimization if too many ICs are generic. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -41 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic.cc View 2 chunks +47 lines, -22 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime-profiler.cc View 4 chunks +34 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
PTAL.
6 years, 4 months ago (2014-08-04 16:00:30 UTC) #1
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-04 16:47:18 UTC) #2
Vyacheslav Egorov (Google)
DBC: I have seen IC based heuristics misfire for code that is high on direct ...
6 years, 4 months ago (2014-08-04 17:59:44 UTC) #3
Toon Verwaest
Surely these IC-based heuristics are a temporary solution until we have more stable feedback.
6 years, 4 months ago (2014-08-04 18:13:31 UTC) #4
Jakob Kummerow
6 years, 4 months ago (2014-08-05 17:06:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r22887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698