ManagePasswordsUIController should make a deep copy of values which it doesn't own.

chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
index f05178bf8b98f1af0621d20e006eca83b438e3bc..0dc0811a86010f062084fccbbff3e9dc2ee6d8eb 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
@@ -93,6 +93,10 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordAutofilled) {
   EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->state());
   EXPECT_FALSE(controller()->PasswordPendingUserDecision());
   EXPECT_EQ(test_form().origin, controller()->origin());
+  EXPECT_EQ(1, controller()->best_matches().size());
+  ASSERT_EQ(1, controller()->best_matches().count(kTestUsername));
+  EXPECT_NE(&test_form(),

[vabr (Chromium), 2014/08/04 15:36:56]

Please say in a comment, that you check the pointers to make sure that the
controller has an independently allocated copy.
Also below.

[vasilii, 2014/08/04 16:20:59]

Done.

+            controller()->best_matches().find(kTestUsername)->second);
 
   ManagePasswordsIconMock mock;
   controller()->UpdateIconAndBubbleState(&mock);
@@ -236,6 +240,10 @@ TEST_F(ManagePasswordsUIControllerTest, BlacklistBlockedAutofill) {
   EXPECT_EQ(password_manager::ui::BLACKLIST_STATE, controller()->state());
   EXPECT_FALSE(controller()->PasswordPendingUserDecision());
   EXPECT_EQ(test_form().origin, controller()->origin());
+  EXPECT_EQ(1, controller()->best_matches().size());
+  ASSERT_EQ(1, controller()->best_matches().count(kTestUsername));
+  EXPECT_NE(&test_form(),
+            controller()->best_matches().find(kTestUsername)->second);
 
   ManagePasswordsIconMock mock;
   controller()->UpdateIconAndBubbleState(&mock);