Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 441643004: Add unit tests for utility functions of FileOperationManager. (Closed)

Created:
6 years, 4 months ago by hirono
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add unit tests for utility functions of FileOperationManager. BUG=315439 TEST=run the js tests. R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288015

Patch Set 1 : Fixed. #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -132 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.html View 1 1 chunk +4 lines, -5 lines 0 comments Download
A chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js View 1 chunk +114 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 2 3 2 chunks +93 lines, -31 lines 0 comments Download
M ui/file_manager/file_manager/common/js/util.js View 2 chunks +0 lines, -96 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 4 months ago (2014-08-06 01:53:55 UTC) #1
yoshiki
lgtm https://codereview.chromium.org/441643004/diff/90001/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/441643004/diff/90001/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode62 ui/file_manager/file_manager/background/js/file_operation_manager.js:62: var ext = match[3] ? match[3] : ''; ...
6 years, 4 months ago (2014-08-06 12:04:08 UTC) #2
hirono
Thanks! https://codereview.chromium.org/441643004/diff/90001/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/441643004/diff/90001/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode62 ui/file_manager/file_manager/background/js/file_operation_manager.js:62: var ext = match[3] ? match[3] : ''; ...
6 years, 4 months ago (2014-08-07 01:57:11 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-07 01:57:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/441643004/110001
6 years, 4 months ago (2014-08-07 02:00:12 UTC) #5
hirono
6 years, 4 months ago (2014-08-07 08:35:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as 288015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698