Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 441623004: [DevTools] Force page redraw when enabling screencast. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
CC:
aandrey+blink_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, nasko+codewatch_chromium.org, paulirish+reviews_chromium.org, pfeldman, vsevik, yurys
Project:
chromium
Visibility:
Public.

Description

[DevTools] Force page redraw when enabling screencast. When attaching to a static page, it may not produce new frames, thus rendering screencast useless. Forcing a frame helps in this case. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M content/browser/devtools/renderer_overrides_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgozman
Could you please take a look? Pavel - at content/browser/devtools; Jochen - at content/; Tom ...
6 years, 4 months ago (2014-08-04 08:35:15 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-04 09:07:01 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-04 09:09:58 UTC) #3
Tom Sepez
Messages LGTM.
6 years, 4 months ago (2014-08-04 17:05:51 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-04 17:25:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/441623004/1
6 years, 4 months ago (2014-08-04 17:27:09 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 19:16:45 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:48:05 UTC) #8
Message was sent while issue was closed.
Change committed as 287421

Powered by Google App Engine
This is Rietveld 408576698