Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3274)

Unified Diff: chrome/browser/history/chrome_history_client.h

Issue 441623002: Eliminate sending NOTIFICATION_TOP_SITES_* from TopSites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/chrome_history_client.h
diff --git a/chrome/browser/history/chrome_history_client.h b/chrome/browser/history/chrome_history_client.h
index 1a02506fb8ab437cbd147c4c26d5acc818eb197f..cbac7dfaa7a1949f50f1bc270cb17905b28cb468 100644
--- a/chrome/browser/history/chrome_history_client.h
+++ b/chrome/browser/history/chrome_history_client.h
@@ -6,15 +6,23 @@
#define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_H_
#include "base/macros.h"
+#include "chrome/browser/history/top_sites_observer.h"
#include "components/history/core/browser/history_client.h"
class BookmarkModel;
+namespace history {
+class TopSites;
+}
+
// This class implements history::HistoryClient to abstract operations that
// depend on Chrome environment.
-class ChromeHistoryClient : public history::HistoryClient {
+class ChromeHistoryClient : public history::HistoryClient,
+ public TopSitesObserver {
public:
- explicit ChromeHistoryClient(BookmarkModel* bookmark_model);
+ explicit ChromeHistoryClient(BookmarkModel* bookmark_model,
sdefresne 2014/08/04 08:47:18 Add the Profile as an additional parameter.
nshaik 2014/08/05 06:38:03 Done.
+ history::TopSites* top_sites);
+ virtual ~ChromeHistoryClient();
// history::HistoryClient:
virtual void BlockUntilBookmarksLoaded() OVERRIDE;
@@ -27,9 +35,14 @@ class ChromeHistoryClient : public history::HistoryClient {
// KeyedService:
virtual void Shutdown() OVERRIDE;
+ // TopSitesObserver:
+ virtual void TopSitesLoaded(history::TopSites* top_sites) OVERRIDE;
+ virtual void TopSitesChanged(history::TopSites* top_sites) OVERRIDE;
+
private:
// The BookmarkModel, this should outlive ChromeHistoryClient.
BookmarkModel* bookmark_model_;
+ history::TopSites* top_sites_;
DISALLOW_COPY_AND_ASSIGN(ChromeHistoryClient);
};
« no previous file with comments | « no previous file | chrome/browser/history/chrome_history_client.cc » ('j') | chrome/browser/history/chrome_history_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698