Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 441613005: Whitelist extensions for oauth2 auto_approve. (Closed)

Created:
6 years, 4 months ago by Joao da Silva
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Whitelist extensions for oauth2 auto_approve. BUG=400474 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287835

Patch Set 1 #

Total comments: 2

Patch Set 2 : trailing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
PTAL, thanks!
6 years, 4 months ago (2014-08-04 19:59:36 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/441613005/diff/1/chrome/common/extensions/api/_manifest_features.json File chrome/common/extensions/api/_manifest_features.json (right): https://codereview.chromium.org/441613005/diff/1/chrome/common/extensions/api/_manifest_features.json#newcode294 chrome/common/extensions/api/_manifest_features.json:294: "A4577D8C2AF4CF26F40CBCA83FFA4251D6F6C8F8", I expect the trailing comma will break
6 years, 4 months ago (2014-08-04 20:09:25 UTC) #2
Joao da Silva
https://codereview.chromium.org/441613005/diff/1/chrome/common/extensions/api/_manifest_features.json File chrome/common/extensions/api/_manifest_features.json (right): https://codereview.chromium.org/441613005/diff/1/chrome/common/extensions/api/_manifest_features.json#newcode294 chrome/common/extensions/api/_manifest_features.json:294: "A4577D8C2AF4CF26F40CBCA83FFA4251D6F6C8F8", On 2014/08/04 20:09:24, kalman wrote: > I expect ...
6 years, 4 months ago (2014-08-04 20:15:24 UTC) #3
not at google - send to devlin
On 2014/08/04 20:15:24, Joao da Silva wrote: > https://codereview.chromium.org/441613005/diff/1/chrome/common/extensions/api/_manifest_features.json > File chrome/common/extensions/api/_manifest_features.json (right): > > ...
6 years, 4 months ago (2014-08-04 20:16:39 UTC) #4
Joao da Silva
> > BTW, there is an annoying presubmit error because these files can't be parsed ...
6 years, 4 months ago (2014-08-04 20:20:23 UTC) #5
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 4 months ago (2014-08-06 16:40:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/441613005/20001
6 years, 4 months ago (2014-08-06 16:42:15 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 19:55:47 UTC) #8
Message was sent while issue was closed.
Change committed as 287835

Powered by Google App Engine
This is Rietveld 408576698