Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6419)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 441593002: Views: Implement keyboard shortcuts for the remove and edit button in the bookmark bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index 614c947c9af4481f8236d65c7e68c6f84464dfec..6557193d10212ad184cb7110db451a34c87154bd 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -125,13 +125,20 @@ void BookmarkBubbleView::WindowClosing() {
bool BookmarkBubbleView::AcceleratorPressed(
const ui::Accelerator& accelerator) {
- if (accelerator.key_code() == ui::VKEY_RETURN) {
- if (edit_button_->HasFocus())
- HandleButtonPressed(edit_button_);
- else
- HandleButtonPressed(close_button_);
- return true;
- } else if (accelerator.key_code() == ui::VKEY_ESCAPE) {
+ ui::KeyboardCode key_code = accelerator.key_code();
+ if (key_code == ui::VKEY_RETURN) {
+ HandleButtonPressed(close_button_);
+ return true;
+ }
+ if (key_code == ui::VKEY_E && accelerator.IsAltDown()) {
+ HandleButtonPressed(edit_button_);
+ return true;
+ }
+ if (key_code == ui::VKEY_R && accelerator.IsAltDown()) {
+ HandleButtonPressed(remove_button_);
+ return true;
+ }
+ if (key_code == ui::VKEY_ESCAPE) {
remove_bookmark_ = newly_bookmarked_;
apply_edits_ = false;
}
@@ -251,6 +258,8 @@ void BookmarkBubbleView::Init() {
}
AddAccelerator(ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE));
+ AddAccelerator(ui::Accelerator(ui::VKEY_E, ui::EF_ALT_DOWN));
+ AddAccelerator(ui::Accelerator(ui::VKEY_R, ui::EF_ALT_DOWN));
}
BookmarkBubbleView::BookmarkBubbleView(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698