chrome/browser/safe_browsing/incident_reporting_service_unittest.cc - Issue 441453002: Support for process-wide incidents in the safe browsing incident reporting service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting_service_unittest.cc

Issue 441453002: Support for process-wide incidents in the safe browsing incident reporting service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: robert comments, proper return call in delayed callback runner Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/delayed_callback_runner.cc ('K') | « chrome/browser/safe_browsing/incident_reporting_service.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting_service_unittest.cc b/chrome/browser/safe_browsing/incident_reporting_service_unittest.cc

index d3dcc190d1fa72737cd0d23ae684293c0e715d50..2439ed91c85bb53112fd42cc652f9f589867e011 100644

--- a/chrome/browser/safe_browsing/incident_reporting_service_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting_service_unittest.cc

@@ -680,6 +680,19 @@ TEST_F(IncidentReportingServiceTest, MigrateOldPref) {

AssertNoUpload();

}

+// Tests that no upload results from adding an incident that is not affiliated

+// with a profile.

+TEST_F(IncidentReportingServiceTest, ProcessWideNoProfileNoUpload) {

+ // Add the test incident.

+ AddTestIncident(NULL);

+ // Let all tasks run.

+ task_runner_->RunUntilIdle();

+ // No upload should have taken place.

+ AssertNoUpload();

// Parallel uploads

// Shutdown during processing

// environment colection taking longer than incident delay timer