render_pdfs - don't render all skps

render_pdfs implements --match

BUG=skia:2743
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/0bef17a678d3d1d551f77f73c716c996ae05c5ca

[hal.canary, 2014-08-06 16:25:23]

PTAL

[mtklein, 2014-08-06 18:48:37]

https://codereview.chromium.org/441423002/diff/60001/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/441423002/diff/60001/gyp/tools.gyp#newcode523
gyp/tools.gyp:523: '../tools/flags/SkCommandLineFlags.cpp',
depend on flags.gyp:flags instead?

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.cpp
File tools/render_pdfs_main.cpp (right):

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:14: #include "SkCommandLineFlags.h"
questionable alphabetism?

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:43: DEFINE_string2(inputPaths, r, NULL,
Usually we default strings to "".

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:204: qsort(array->begin(), array->count(),
sizeof(SkString),
Using qsort with non-POD data seems error prone.  Can you use SkTSort?

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:237: sort_string_array(&files);
Or maybe just don't sort?

[hal.canary, 2014-08-06 20:11:24]

https://codereview.chromium.org/441423002/diff/60001/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/441423002/diff/60001/gyp/tools.gyp#newcode523
gyp/tools.gyp:523: '../tools/flags/SkCommandLineFlags.cpp',
On 2014/08/06 18:48:36, mtklein wrote:
> depend on flags.gyp:flags instead?

Done.

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.cpp
File tools/render_pdfs_main.cpp (right):

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:14: #include "SkCommandLineFlags.h"
On 2014/08/06 18:48:36, mtklein wrote:
> questionable alphabetism?

Done.

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:43: DEFINE_string2(inputPaths, r, NULL,
On 2014/08/06 18:48:36, mtklein wrote:
> Usually we default strings to "".

Done.

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:204: qsort(array->begin(), array->count(),
sizeof(SkString),
On 2014/08/06 18:48:36, mtklein wrote:
> Using qsort with non-POD data seems error prone.  Can you use SkTSort?

Done.

https://codereview.chromium.org/441423002/diff/60001/tools/render_pdfs_main.c...
tools/render_pdfs_main.cpp:237: sort_string_array(&files);
On 2014/08/06 18:48:36, mtklein wrote:
> Or maybe just don't sort?

I am sorting so that I can easily verify that the match is working correctly.

[mtklein, 2014-08-06 20:41:53]

lgtm

[hal.canary, 2014-08-07 14:16:03]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-08-07 14:16:23]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/441423002/100001

[commit-bot: I haz the power, 2014-08-07 14:24:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

[hal.canary, 2014-08-07 14:24:32]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2014-08-07 14:24:41]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-08-07 14:24:43]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/441423002/100001

[commit-bot: I haz the power, 2014-08-07 14:24:52]

Change committed as 0bef17a678d3d1d551f77f73c716c996ae05c5ca