Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: Tools/GardeningServer/ui/test/ct-commit-list-tests.html

Issue 441393002: Collapse commit list by default in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-list.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/test/ct-commit-list-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-commit-list-tests.html b/Tools/GardeningServer/ui/test/ct-commit-list-tests.html
index 04dfa6e52c178332d0f647fab53446f9eb7f415c..48815c9fea7a129cdc5e1b6cd60c287be869c1a1 100644
--- a/Tools/GardeningServer/ui/test/ct-commit-list-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-commit-list-tests.html
@@ -18,27 +18,42 @@ describe('ct-commit-list', function() {
beforeEach(function(done) {
list = document.createElement('ct-commit-list');
-
setTimeout(done);
});
describe('commit list UI', function() {
beforeEach(function(done) {
+ var repos = [
+ { commits: [ new CTCommitMock(), new CTCommitMock() ],
+ expanded: false },
+ { commits: [ new CTCommitMock(), new CTCommitMock() ],
+ expanded: false }
+ ];
+
var CommitList = Object.create(Object);
CommitList.prototype.repositories = function() {
- return [
- { commits: [ new CTCommitMock(), new CTCommitMock() ] },
- { commits: [ new CTCommitMock(), new CTCommitMock() ] }
- ]
+ return repos;
};
list.commitList = CommitList;
setTimeout(done);
});
- it('should show all commits in revision range', function() {
+ it('should show no commits by default', function() {
var commits = list.shadowRoot.querySelectorAll('ct-commit');
- assert.lengthOf(commits, 4);
+ assert.lengthOf(commits, 0);
+ });
+
+ describe('expanded test', function() {
+ beforeEach(function(done) {
+ list.commitList.repositories().first().expanded = true;
+ list.commitList.repositories().last().expanded = true;
+ setTimeout(done);
+ });
+
+ it('should show commits when expanded', function() {
+ assert.lengthOf(list.shadowRoot.querySelectorAll('ct-commit'), 4);
+ });
});
});
});
« no previous file with comments | « Tools/GardeningServer/ui/ct-commit-list.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698