Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 441363003: Android: allow to kill a child process in instrumentation testing. (Closed)

Created:
6 years, 4 months ago by ppi
Modified:
6 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Android: allow to kill a child process in instrumentation testing. This patch exposes a method to kill a child process service of a given pid, allowing regression integration test for http://crbug.com/399521 on the embedder side. BUG=399521 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ppi
Hi Yaron, ptal.
6 years, 4 months ago (2014-08-06 14:06:21 UTC) #1
Yaron
lgtm
6 years, 4 months ago (2014-08-06 18:24:32 UTC) #2
ppi
Thanks!
6 years, 4 months ago (2014-08-07 12:13:05 UTC) #3
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 4 months ago (2014-08-07 12:13:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/441363003/1
6 years, 4 months ago (2014-08-07 12:14:12 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:21:32 UTC) #6
Message was sent while issue was closed.
Change committed as 288071

Powered by Google App Engine
This is Rietveld 408576698