media/filters/skcanvas_video_renderer.h - Issue 441303002: 2D Canvas doesn't blend video with the destination buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/skcanvas_video_renderer.h

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove redundant SkCanvas::clear on compositor Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_browsertest.cc ('K') | « content/renderer/media/webmediaplayer_ms.cc ('k') | media/filters/skcanvas_video_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/filters/skcanvas_video_renderer.h

diff --git a/media/filters/skcanvas_video_renderer.h b/media/filters/skcanvas_video_renderer.h

index 9e3622d79c531058aee068ae8bce1e3ccc8de2e8..e243d28b9938bf261466570a1e10038e4333e0ef 100644

--- a/media/filters/skcanvas_video_renderer.h

+++ b/media/filters/skcanvas_video_renderer.h

@@ -8,6 +8,7 @@

#include "base/time/time.h"

#include "media/base/media_export.h"

#include "third_party/skia/include/core/SkBitmap.h"

+#include "third_party/skia/include/core/SkXfermode.h"

#include "ui/gfx/rect.h"

class SkCanvas;

@@ -30,7 +31,8 @@ class MEDIA_EXPORT SkCanvasVideoRenderer {

void Paint(media::VideoFrame* video_frame,

SkCanvas* canvas,

const gfx::RectF& dest_rect,

- uint8 alpha);

+ uint8 alpha,

+ SkXfermode::Mode mode);

private:

// An RGB bitmap and corresponding timestamp of the previously converted