cc/resources/video_resource_updater.cc - Issue 441303002: 2D Canvas doesn't blend video with the destination buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/video_resource_updater.cc

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove redundant SkCanvas::clear on compositor Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_browsertest.cc » ('j') | content/browser/renderer_host/render_widget_host_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/resources/video_resource_updater.cc

diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc

index a1286b917b4f2bde8af4248eb7654b2da202db4d..a8ba4ae7056fd60f215a244536f73d29e4ec7f2e 100644

--- a/cc/resources/video_resource_updater.cc

+++ b/cc/resources/video_resource_updater.cc

@@ -249,10 +249,12 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(

{

ResourceProvider::ScopedWriteLockSoftware lock(

resource_provider_, plane_resources[0].resource_id);

+ // Use Src mode to avoid clearing the buffer first.

video_renderer_->Paint(video_frame.get(),

lock.sk_canvas(),

video_frame->visible_rect(),

- 0xff);

+ 0xff,

+ SkXfermode::kSrc_Mode);

Justin Novosad 2014/08/06 18:30:29 Excellent!

}

RecycleResourceData recycle_data = {