Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase to ToT. improve TODO comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // Poster image, as defined in the <video> element. 109 // Poster image, as defined in the <video> element.
110 virtual void setPoster(const blink::WebURL& poster) OVERRIDE; 110 virtual void setPoster(const blink::WebURL& poster) OVERRIDE;
111 111
112 // Methods for painting. 112 // Methods for painting.
113 // FIXME: This path "only works" on Android. It is a workaround for the 113 // FIXME: This path "only works" on Android. It is a workaround for the
114 // issue that Skia could not handle Android's GL_TEXTURE_EXTERNAL_OES texture 114 // issue that Skia could not handle Android's GL_TEXTURE_EXTERNAL_OES texture
115 // internally. It should be removed and replaced by the normal paint path. 115 // internally. It should be removed and replaced by the normal paint path.
116 // https://code.google.com/p/skia/issues/detail?id=1189 116 // https://code.google.com/p/skia/issues/detail?id=1189
117 virtual void paint(blink::WebCanvas* canvas, 117 virtual void paint(blink::WebCanvas* canvas,
118 const blink::WebRect& rect, 118 const blink::WebRect& rect,
119 unsigned char alpha,
120 SkXfermode::Mode mode);
121 // TODO(dshwang): remove it because above method replaces. crbug.com/401027
122 virtual void paint(blink::WebCanvas* canvas,
123 const blink::WebRect& rect,
119 unsigned char alpha); 124 unsigned char alpha);
120 125
121 virtual bool copyVideoTextureToPlatformTexture( 126 virtual bool copyVideoTextureToPlatformTexture(
122 blink::WebGraphicsContext3D* web_graphics_context, 127 blink::WebGraphicsContext3D* web_graphics_context,
123 unsigned int texture, 128 unsigned int texture,
124 unsigned int level, 129 unsigned int level,
125 unsigned int internal_format, 130 unsigned int internal_format,
126 unsigned int type, 131 unsigned int type,
127 bool premultiply_alpha, 132 bool premultiply_alpha,
128 bool flip_y); 133 bool flip_y);
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 483
479 // NOTE: Weak pointers must be invalidated before all other member variables. 484 // NOTE: Weak pointers must be invalidated before all other member variables.
480 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_; 485 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_;
481 486
482 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid); 487 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid);
483 }; 488 };
484 489
485 } // namespace content 490 } // namespace content
486 491
487 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 492 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698