Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: media/filters/skcanvas_video_renderer.cc

Issue 441303002: 2D Canvas doesn't blend video with the destination buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/resources/video_resource_updater.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/filters/skcanvas_video_renderer.h" 5 #include "media/filters/skcanvas_video_renderer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "media/base/video_frame.h" 8 #include "media/base/video_frame.h"
9 #include "media/base/yuv_convert.h" 9 #include "media/base/yuv_convert.h"
10 #include "third_party/libyuv/include/libyuv.h" 10 #include "third_party/libyuv/include/libyuv.h"
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 return; 206 return;
207 } 207 }
208 208
209 // Check if we should convert and update |last_frame_|. 209 // Check if we should convert and update |last_frame_|.
210 if (last_frame_.isNull() || 210 if (last_frame_.isNull() ||
211 video_frame->timestamp() != last_frame_timestamp_) { 211 video_frame->timestamp() != last_frame_timestamp_) {
212 ConvertVideoFrameToBitmap(video_frame, &last_frame_); 212 ConvertVideoFrameToBitmap(video_frame, &last_frame_);
213 last_frame_timestamp_ = video_frame->timestamp(); 213 last_frame_timestamp_ = video_frame->timestamp();
214 } 214 }
215 215
216 // Use SRC mode so we completely overwrite the buffer (in case we have alpha)
217 // this means we don't need the extra cost of clearing the buffer first.
218 paint.setXfermode(SkXfermode::Create(SkXfermode::kSrc_Mode));
219
220 // Paint using |last_frame_|. 216 // Paint using |last_frame_|.
221 paint.setFilterLevel(SkPaint::kLow_FilterLevel); 217 paint.setFilterLevel(SkPaint::kLow_FilterLevel);
dshwang 2014/08/06 11:11:12 Is Low filter really needed?
222 canvas->drawBitmapRect(last_frame_, NULL, dest, &paint); 218 canvas->drawBitmapRect(last_frame_, NULL, dest, &paint);
223 } 219 }
224 220
225 } // namespace media 221 } // namespace media
OLDNEW
« no previous file with comments | « cc/resources/video_resource_updater.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698