src/factory.cc - Issue 441273002: Reland "Make --always-opt also optimize toplevel code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 441273002: Reland "Make --always-opt also optimize toplevel code." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Well, yeah. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index e3a19a1e4ba988a0b19b00219e8ed50d83cb3a23..f2a872c2ecbc4d886063e48ad467ae281a898e9d 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -5,6 +5,7 @@

#include "src/factory.h"

#include "src/allocation-site-scopes.h"

+#include "src/bootstrapper.h"

#include "src/conversions.h"

#include "src/isolate-inl.h"

#include "src/macro-assembler.h"

@@ -1377,7 +1378,8 @@ Handle<JSFunction> Factory::NewFunctionFromSharedFunctionInfo(

if (isolate()->use_crankshaft() &&

FLAG_always_opt &&

result->is_compiled() &&

- !info->is_toplevel() &&

+ // TODO(mstarzinger): Extend to optimization of builtin code.

+ !isolate()->bootstrapper()->IsActive() &&

info->allows_lazy_compilation() &&

!info->optimization_disabled() &&

!isolate()->DebuggerHasBreakPoints()) {

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »