Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 441253003: Work around GC bug to fix flaky autoplay tests (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Work around GC bug to fix flaky autoplay tests With these changes both tests appear to be reliable. BUG=357080 BUG=400659 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/autoplay.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/media/autoplay-with-preload-none.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-06 11:36:19 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 4 months ago (2014-08-06 15:52:19 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-06 16:37:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/441253003/1
6 years, 4 months ago (2014-08-06 16:38:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-06 17:42:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 18:27:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21399)
6 years, 4 months ago (2014-08-06 18:27:09 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-06 18:58:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/441253003/1
6 years, 4 months ago (2014-08-06 19:00:24 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 20:00:46 UTC) #10
Message was sent while issue was closed.
Change committed as 179647

Powered by Google App Engine
This is Rietveld 408576698