rebaseline_server: UI improvements + set reviewed-by-human on commit

gm/rebaseline_server/static/loader.js

 /*
  * Loader:
  * Reads GM result reports written out by results.py, and imports
  * them into $scope.categories and $scope.testData .
  */
 var Loader = angular.module(
     'Loader',
     []
 );
 
 
 // TODO(epoger): Combine ALL of our filtering operations (including
 // truncation) into this one filter, so that runs most efficiently?
 // (We would have to make sure truncation still took place after
 // sorting, though.)
 Loader.filter(
   'removeHiddenItems',
   function() {
     return function(unfilteredItems, hiddenResultTypes, hiddenConfigs,
                     viewingTab) {
       var filteredItems = [];
       for (var i = 0; i < unfilteredItems.length; i++) {
         var item = unfilteredItems[i];
-        // For performance, we examine the "set" objects directly rather
-        // than calling $scope.isValueInSet().
+        // For performance, we examine the "set" objects directly rather
+        // than calling $scope.isValueInSet().
+        // Besides, I don't think we have access to $scope in here...
         if (!(true == hiddenResultTypes[item.resultType]) &&
             !(true == hiddenConfigs[item.config]) &&
             (viewingTab == item.tab)) {
           filteredItems.push(item);
         }
       }
       return filteredItems;
     };
   }
 );
@@ skipping 15 matching lines @@
     $http.get("/results/" + resultsToLoad).success(
       function(data, status, header, config) {
         $scope.loadingMessage = "Processing data, please wait...";
 
         $scope.header = data.header;
         $scope.categories = data.categories;
         $scope.testData = data.testData;
         $scope.sortColumn = 'test';
         $scope.showTodos = false;
 
+        $scope.showSubmitAdvancedSettings = false;
+        $scope.submitAdvancedSettings = {};
+        $scope.submitAdvancedSettings['reviewed-by-human'] = true;
+        $scope.submitAdvancedSettings['ignore-failures'] = false;
+        $scope.submitAdvancedSettings['bug'] = '';
+
         // Create the list of tabs (lists into which the user can file each
         // test).  This may vary, depending on isEditable.
         $scope.tabs = [
           'Unfiled', 'Hidden'
         ];
         if (data.header.isEditable) {
           $scope.tabs = $scope.tabs.concat(
               ['Pending Approval']);
         }
         $scope.defaultTab = $scope.tabs[0];
         $scope.viewingTab = $scope.defaultTab;
 
         // Track the number of results on each tab.
         $scope.numResultsPerTab = {};
         for (var i = 0; i < $scope.tabs.length; i++) {
           $scope.numResultsPerTab[$scope.tabs[i]] = 0;
         }
         $scope.numResultsPerTab[$scope.defaultTab] = $scope.testData.length;
 
         // Add index and tab fields to all records.
         for (var i = 0; i < $scope.testData.length; i++) {
           $scope.testData[i].index = i;
           $scope.testData[i].tab = $scope.defaultTab;
         }
 
-        // Arrays within which the user can toggle individual elements.
+        // Arrays within which the user can toggle individual elements.
         $scope.selectedItems = [];
 
-        // Sets within which the user can toggle individual elements.
+        // Sets within which the user can toggle individual elements.
         $scope.hiddenResultTypes = {
           'failure-ignored': true,
           'no-comparison': true,
           'succeeded': true,
         };
         $scope.hiddenConfigs = {};
 
         $scope.updateResults();
         $scope.loadingMessage = "";
         $scope.windowTitle = "Current GM Results";
       }
     ).error(
       function(data, status, header, config) {
         $scope.loadingMessage = "Failed to load results of type '"
             + resultsToLoad + "'";
         $scope.windowTitle = "Failed to Load GM Results";
       }
     );
 
 
     //
+    // Select/Clear/Toggle all tests.
+    //
+
+    /**
+     * Select all currently showing tests.
+     */
+    $scope.selectAllItems = function() {
+      var numItemsShowing = $scope.limitedTestData.length;
+      for (var i = 0; i < numItemsShowing; i++) {
+        var index = $scope.limitedTestData[i].index;
+        if (!$scope.isValueInArray(index, $scope.selectedItems)) {
+          $scope.toggleValueInArray(index, $scope.selectedItems);
+        }
+      }
+    }
+
+    /**
+     * Deselect all currently showing tests.
+     */
+    $scope.clearAllItems = function() {
+      var numItemsShowing = $scope.limitedTestData.length;
+      for (var i = 0; i < numItemsShowing; i++) {
+        var index = $scope.limitedTestData[i].index;
+        if ($scope.isValueInArray(index, $scope.selectedItems)) {
+          $scope.toggleValueInArray(index, $scope.selectedItems);
+        }
+      }
+    }
+
+    /**
+     * Toggle selection of all currently showing tests.
+     */
+    $scope.toggleAllItems = function() {
+      var numItemsShowing = $scope.limitedTestData.length;
+      for (var i = 0; i < numItemsShowing; i++) {
+        var index = $scope.limitedTestData[i].index;
+        $scope.toggleValueInArray(index, $scope.selectedItems);
+      }
+    }
+
+
+    //
     // Tab operations.
     //
 
     /**
      * Change the selected tab.
      *
      * @param tab (string): name of the tab to select
      */
     $scope.setViewingTab = function(tab) {
       $scope.viewingTab = tab;
@@ skipping 76 matching lines @@
             $scope.filteredTestData, $scope.displayLimit);
       } else {
         $scope.filteredTestData =
             $filter("orderBy")(
                 $filter("filter")(
                     $scope.testData,
                     {tab: $scope.viewingTab},
                     true
                 ),
                 $scope.sortColumn);
-        $scope.limitedTestData = $filter("limitTo")(
-            $scope.filteredTestData, $scope.displayLimit);
+        $scope.limitedTestData = $scope.filteredTestData;
       }
       $scope.imageSize = $scope.imageSizePending;
       $scope.setUpdatesPending(false);
     }
 
     /**
      * Re-sort the displayed results.
      *
      * @param sortColumn (string): name of the column to sort on
      */
     $scope.sortResultsBy = function(sortColumn) {
       $scope.sortColumn = sortColumn;
       $scope.updateResults();
     }
 
 
     //
     // Operations for sending info back to the server.
     //
 
     /**
      * Tell the server that the actual results of these particular tests
      * are acceptable.
      *
      * @param testDataSubset an array of test results, most likely a subset of
      *        $scope.testData (perhaps with some modifications)
      */
     $scope.submitApprovals = function(testDataSubset) {
       $scope.submitPending = true;
+
+      // Convert bug text field to null or 1-item array.
+      var bugs = null;
+      var bugNumber = parseInt($scope.submitAdvancedSettings['bug']);
+      if (!isNaN(bugNumber)) {
+        bugs = [bugNumber];
+      }
+
+      // TODO(epoger): This is a suboptimal way to prevent users from
+      // rebaselining failures in alternative renderModes, but it does work.
+      // For a better solution, see
+      // https://code.google.com/p/skia/issues/detail?id=1748 ('gm: add new
+      // result type, RenderModeMismatch')
+      var encounteredComparisonConfig = false;
+
       var newResults = [];
       for (var i = 0; i < testDataSubset.length; i++) {
         var actualResult = testDataSubset[i];
         var expectedResult = {
           builder: actualResult['builder'],
           test: actualResult['test'],
           config: actualResult['config'],
           expectedHashType: actualResult['actualHashType'],
           expectedHashDigest: actualResult['actualHashDigest'],
         };
+        if (0 == expectedResult.config.indexOf('comparison-')) {
+          encounteredComparisonConfig = true;
+        }
+
+        // Advanced settings...
+        expectedResult['reviewed-by-human'] =
+            $scope.submitAdvancedSettings['reviewed-by-human'];
+        if (true == $scope.submitAdvancedSettings['ignore-failure']) {
+          // if it's false, don't send it at all (just keep the default)
+          expectedResult['ignoreFailure'] = true;
+        }
+        expectedResult['bugs'] = bugs;
+
         newResults.push(expectedResult);
       }
+      if (encounteredComparisonConfig) {
+        alert("Approval failed -- you cannot approve results with config " +
+            "type comparison-*");
+        $scope.submitPending = false;
+        return;
+      }
       $http({
         method: "POST",
         url: "/edits",
         data: {
           oldResultsType: $scope.header.type,
           oldResultsHash: $scope.header.dataHash,
           modifications: newResults
         }
       }).success(function(data, status, headers, config) {
         var itemIndicesToMove = [];
@@ skipping 95 matching lines @@
      *
      * @param secondsPastEpoch (numeric): seconds past epoch in UTC
      */
     $scope.localTimeString = function(secondsPastEpoch) {
       var d = new Date(secondsPastEpoch * 1000);
       return d.toString();
     }
 
   }
 );