rebaseline_server: UI improvements + set reviewed-by-human on commit

rebaseline_server: UI improvements + set reviewed-by-human on commit

- select/clear/toggle all tests
- display "bugs" column
- set reviewed-by-human on commit
- a couple more tiny fixes, TODOs adjusted, etc.

(SkipBuildbotRuns)

R=senorblanco@chromium.org

Committed: https://code.google.com/p/skia/source/detail?r=11970

[epoger, 2013-10-25 16:38:26]

Ready for review at patchset 1.

If you'd like to play around with the UI, I left it running at
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...

$ ./server.py --export --port 8111 --reload 300

You can compare its behavior to the checked-in one, which is running at
http://wpgntat-ubiq141.hot.corp.google.com:6823/static/view.html?resultsToLoa...

https://codereview.chromium.org/44123004/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (left):

https://codereview.chromium.org/44123004/diff/1/gm/rebaseline_server/results....
gm/rebaseline_server/results.py:288: # 2. ignore-tests.txt
This case doesn't happen anymore.

https://codereview.chromium.org/44123004/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/44123004/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:24: // For performance, we examine the
"set" objects directly rather
fixed some tabs -> spaces

[epoger, 2013-10-25 21:14:30]

Ready for review (still) at patchset 2.

Patchset 2: added the ability to set advanced settings on the Pending Approval
page.  It won't be the final UI for submitting baselines for known-to-fail
tests, but it will allow us to do so.

I restarted the test server with --editable, so if you go to 
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...
you'll be able to see the new "Advanced settings" on the Pending Approval tab.

[bsalomon, 2013-10-25 21:37:08]

On 2013/10/25 21:14:30, epoger wrote:
> Ready for review (still) at patchset 2.
> 
> Patchset 2: added the ability to set advanced settings on the Pending Approval
> page.  It won't be the final UI for submitting baselines for known-to-fail
> tests, but it will allow us to do so.
> 
> I restarted the test server with --editable, so if you go to 
>
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...
> you'll be able to see the new "Advanced settings" on the Pending Approval tab.

The current failures are all in config comparison-serialize. While it's great to
see the images in the tool, should they be movable to pending approval? My
understanding is that we don't maintain separate baseline images for the modes,
rather we require that they match the 8888 config, but I could be wrong.

[epoger, 2013-10-26 03:20:58]

On 2013/10/25 21:37:08, bsalomon wrote:
> The current failures are all in config comparison-serialize. While it's great
to
> see the images in the tool, should they be movable to pending approval? My
> understanding is that we don't maintain separate baseline images for the
modes,
> rather we require that they match the 8888 config, but I could be wrong.

Good point, I hadn't thought about that.

I think this is another vote in favor of
https://code.google.com/p/skia/issues/detail?id=1748 ('gm: add new result type,
RenderModeMismatch').  By handling those failures as a completely separate
resultType, it should be fairly straightforward to prevent them from being
rebaselined.

In the meanwhile, I came up with a simpler guard against this.  Please see
patchset 3, and let me know if you think that's good enough for now.

[Stephen White, 2013-10-26 13:50:02]

LGTM

https://codereview.chromium.org/44123004/diff/130001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/44123004/diff/130001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/loader.js:126: for (var i=0; i<numItemsShowing; i++)
{
Nit: Google JS style requires spaces around conditionals.

https://codereview.chromium.org/44123004/diff/130001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/loader.js:139: for (var i=0; i<numItemsShowing; i++)
{
Same here.

https://codereview.chromium.org/44123004/diff/130001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/loader.js:152: for (var i=0; i<numItemsShowing; i++)
{
Same here.

[epoger, 2013-10-26 14:31:14]

Committed patchset #4 manually as r11970 (presubmit successful).