Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 441223002: Update LayoutTests by removing child elements of <shadow> element (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 4 months ago
Reviewers:
esprehn, hayato
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Update LayoutTests by removing child elements of <shadow> element Remove the children of <shadow> element from the layout tests. Even though child elements are ignored, it can be confusing sometimes. BUG=334957 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M LayoutTests/editing/shadow/breaking-editing-boundaries.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-reprojection-complex.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-reprojection-shadow.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/nested-reprojection-inconsistent.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/reprojection-attribute-modified.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reprojection-className-modified.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reprojection-id-modified.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-and-list-elements.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-div-reflow.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-reprojection-fallback.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-reprojection2.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-button.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-button-complex-shadow.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-button-only-shadow.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
deepak.sa
PTAL? Thanks!
6 years, 4 months ago (2014-08-07 07:07:52 UTC) #1
hayato
On 2014/08/07 07:07:52, deepak.sa wrote: > PTAL? > Thanks!
6 years, 4 months ago (2014-08-07 07:15:14 UTC) #2
hayato
LGTM. You might want to update other layout tests which constructs DOM tree dynamically. For ...
6 years, 4 months ago (2014-08-07 07:20:24 UTC) #3
deepak.sa
On 2014/08/07 07:20:24, hayato wrote: > LGTM. > > You might want to update other ...
6 years, 4 months ago (2014-08-07 07:24:49 UTC) #4
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 4 months ago (2014-08-07 07:25:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/441223002/1
6 years, 4 months ago (2014-08-07 07:25:18 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 08:49:11 UTC) #7
Message was sent while issue was closed.
Change committed as 179694

Powered by Google App Engine
This is Rietveld 408576698